Lad Prabhakar cee409bbba Input: gpio-keys - cancel delayed work only in case of GPIO ... gpio_keys module can either accept gpios or interrupts. The module initializes delayed work in case of gpios only and is only used if debounce timer is not used, so make sure cancel_delayed_work_sync() is called only when its gpio-backed and debounce_use_hrtimer is false. This fixes the issue seen below when the gpio_keys module is unloaded and an interrupt pin is used instead of GPIO: [ 360.297569] ------------[ cut here ]------------ [ 360.302303] WARNING: CPU: 0 PID: 237 at kernel/workqueue.c:3066 __flush_work+0x414/0x470 [ 360.310531] Modules linked in: gpio_keys(-) [ 360.314797] CPU: 0 PID: 237 Comm: rmmod Not tainted 5.18.0-rc5-arm64-renesas-00116-g73636105874d-dirty #166 [ 360.324662] Hardware name: Renesas SMARC EVK based on r9a07g054l2 (DT) [ 360.331270] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 360.338318] pc : __flush_work+0x414/0x470 [ 360.342385] lr : __cancel_work_timer+0x140/0x1b0 [ 360.347065] sp : ffff80000a7fba00 [ 360.350423] x29: ffff80000a7fba00 x28: ffff000012b9c5c0 x27: 0000000000000000 [ 360.357664] x26: ffff80000a7fbb80 x25: ffff80000954d0a8 x24: 0000000000000001 [ 360.364904] x23: ffff800009757000 x22: 0000000000000000 x21: ffff80000919b000 [ 360.372143] x20: ffff00000f5974e0 x19: ffff00000f5974e0 x18: ffff8000097fcf48 [ 360.379382] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000053f40 [ 360.386622] x14: ffff800009850e88 x13: 0000000000000002 x12: 000000000000a60c [ 360.393861] x11: 000000000000a610 x10: 0000000000000000 x9 : 0000000000000008 [ 360.401100] x8 : 0101010101010101 x7 : 00000000a473c394 x6 : 0080808080808080 [ 360.408339] x5 : 0000000000000001 x4 : 0000000000000000 x3 : ffff80000919b458 [ 360.415578] x2 : ffff8000097577f0 x1 : 0000000000000001 x0 : 0000000000000000 [ 360.422818] Call trace: [ 360.425299] __flush_work+0x414/0x470 [ 360.429012] __cancel_work_timer+0x140/0x1b0 [ 360.433340] cancel_delayed_work_sync+0x10/0x18 [ 360.437931] gpio_keys_quiesce_key+0x28/0x58 [gpio_keys] [ 360.443327] devm_action_release+0x10/0x18 [ 360.447481] release_nodes+0x8c/0x1a0 [ 360.451194] devres_release_all+0x90/0x100 [ 360.455346] device_unbind_cleanup+0x14/0x60 [ 360.459677] device_release_driver_internal+0xe8/0x168 [ 360.464883] driver_detach+0x4c/0x90 [ 360.468509] bus_remove_driver+0x54/0xb0 [ 360.472485] driver_unregister+0x2c/0x58 [ 360.476462] platform_driver_unregister+0x10/0x18 [ 360.481230] gpio_keys_exit+0x14/0x828 [gpio_keys] [ 360.486088] __arm64_sys_delete_module+0x1e0/0x270 [ 360.490945] invoke_syscall+0x40/0xf8 [ 360.494661] el0_svc_common.constprop.3+0xf0/0x110 [ 360.499515] do_el0_svc+0x20/0x78 [ 360.502877] el0_svc+0x48/0xf8 [ 360.505977] el0t_64_sync_handler+0x88/0xb0 [ 360.510216] el0t_64_sync+0x148/0x14c [ 360.513930] irq event stamp: 4306 [ 360.517288] hardirqs last enabled at (4305): [<ffff8000080b0300>] __cancel_work_timer+0x130/0x1b0 [ 360.526359] hardirqs last disabled at (4306): [<ffff800008d194fc>] el1_dbg+0x24/0x88 [ 360.534204] softirqs last enabled at (4278): [<ffff8000080104a0>] _stext+0x4a0/0x5e0 [ 360.542133] softirqs last disabled at (4267): [<ffff8000080932ac>] irq_exit_rcu+0x18c/0x1b0 [ 360.550591] ---[ end trace 0000000000000000 ]--- Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Link: https://lore.kernel.org/r/20220524135822.14764-1-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>		2022-05-26 09:56:40 -07:00
..
accessibility	speakup-dectlk: Restore pitch setting	2022-02-08 12:15:04 +01:00
acpi	Revert "ACPI: scan: Do not add device IDs from _CID if _HID is not valid"	2022-03-16 11:23:05 +01:00
amba
android
ata	ata: pata_hpt37x: disable primary channel on HPT371	2022-02-23 09:39:37 +09:00
atm	atm: eni: Add check for dma_map_single	2022-03-15 11:01:52 +00:00
auxdisplay	auxdisplay: lcd2s: Use proper API to free the instance of charlcd object	2022-03-03 00:30:31 +01:00
base	regmap: Fix for v5.17	2022-02-25 12:30:01 -08:00
bcma
block	xen: XSA-396 security patches for v5.17	2022-03-09 20:44:17 -08:00
bluetooth	virtio,vdpa,qemu_fw_cfg: features, cleanups, fixes	2022-01-18 10:05:48 +02:00
bus	bus: mhi: pci_generic: Add mru_default for Cinterion MV31-W	2022-02-06 13:19:46 +01:00
cdrom	cdrom: simplify subdirectory registration with register_sysctl()	2022-01-22 08:33:35 +02:00
char	virtio_console: break out of buf poll on remove	2022-03-04 08:33:22 -05:00
clk	clk: lan966x: Fix linking error	2022-02-24 16:53:24 -08:00
clocksource	ARM: dts: Use 32KiHz oscillator on devkit8000	2022-02-18 10:08:45 +02:00
comedi
connector	connector/cn_proc: Use task_is_in_init_pid_ns()	2022-01-26 18:57:09 -08:00
counter	counter: Stop using dev_get_drvdata() to get the counter device	2022-03-15 19:24:13 +01:00
cpufreq	cpufreq: qcom-hw: Delay enabling throttle_irq	2022-02-09 13:18:49 +05:30
cpuidle
crypto	crypto: qcom-rng - ensure buffer for generate is completely filled	2022-03-14 14:41:04 +12:00
cxl
dax	Merge branch 'akpm' (patches from Andrew)	2022-01-15 20:37:06 +02:00
dca
devfreq
dio
dma	dmaengine: shdma: Fix runtime PM imbalance on error	2022-02-15 11:04:16 +05:30
dma-buf	dma-buf: heaps: Fix potential spectre v1 gadget	2022-02-01 13:18:09 +05:30
edac	EDAC: Fix calculation of returned address and next offset in edac_align_ptr()	2022-02-15 15:54:46 +01:00
eisa
extcon
firewire
firmware	Final EFI fix for v5.17	2022-03-16 11:57:46 -07:00
fpga
fsi
gnss
gpio	Revert "gpio: Revert regression in sysfs-gpio (gpiolib.c)"	2022-03-15 09:59:08 -07:00
gpu	drm: Don't make DRM_PANEL_BRIDGE dependent on DRM_KMS_HELPERS	2022-03-17 11:07:57 +01:00
greybus
hid	HID: google: modify HID device groups of eel	2022-03-14 21:11:13 -07:00
hsi
hv	Drivers: hv: utils: Make use of the helper macro LIST_HEAD()	2022-02-09 14:33:21 +00:00
hwmon	hwmon: (pmbus) Clear pmbus fault/warning bits after read	2022-02-22 08:15:39 -08:00
hwspinlock
hwtracing
i2c	i2c: brcmstb: fix support for DSL and CM variants	2022-02-18 10:37:33 +01:00
i3c	i3c: master: dw: check return of dw_i3c_master_get_free_pos()	2022-01-13 02:05:50 +01:00
idle
iio	1st set of IIO fixes for the 5.17 cycle.	2022-02-21 17:58:09 +01:00
infiniband	RDMA/cma: Do not change route.addr.src_addr outside state checks	2022-02-25 16:46:51 -04:00
input	Input: gpio-keys - cancel delayed work only in case of GPIO	2022-05-26 09:56:40 -07:00
interconnect
iommu	iommu/tegra-smmu: Fix missing put_device() call in tegra_smmu_find	2022-02-28 14:01:57 +01:00
ipack
irqchip	irqchip/sifive-plic: Add missing thead,c900-plic match string	2022-02-02 10:49:29 +00:00
isdn	isdn: hfcpci: check the return value of dma_set_mask() in setup_hw()	2022-03-07 11:27:12 +00:00
leds	LED updates for 5.17. Nothing major is happening here.	2022-01-12 16:59:22 -08:00
macintosh	macintosh/mac_hid.c: simplify subdirectory registration with register_sysctl()	2022-01-22 08:33:35 +02:00
mailbox	- qcom: misc updates to qcom-ipcc driver	2022-01-13 11:19:07 -08:00
mcb
md	block: fix surprise removal for drivers calling blk_set_queue_dying	2022-02-17 07:54:03 -07:00
media	bitmap patches for 5.17-rc1	2022-01-23 06:20:44 +02:00
memory	MTD core changes:	2022-01-11 11:35:28 -08:00
memstick
message	scsi: message: fusion: mptctl: Use dma_alloc_coherent()	2022-01-10 10:33:52 -05:00
mfd	driver core changes for 5.17-rc1	2022-01-12 11:11:34 -08:00
misc	eeprom: ee1004: limit i2c reads to I2C_SMBUS_BLOCK_MAX	2022-02-04 16:27:44 +01:00
mmc	mmc: core: Restore (almost) the busy polling for MMC_SEND_OP_COND	2022-03-07 11:47:39 +01:00
most
mtd	mtd: rawnand: omap2: Actually prevent invalid configuration and build error	2022-03-07 17:46:54 +01:00
mux
net	iavf: Fix hang during reboot/shutdown	2022-03-17 09:37:37 -07:00
nfc	NFC: port100: fix use-after-free in port100_send_complete	2022-03-09 19:59:34 -08:00
ntb	ntb: intel: fix port config status offset for SPR	2022-01-28 10:19:16 -05:00
nubus	proc: remove PDE_DATA() completely	2022-01-22 08:33:37 +02:00
nvdimm	virtio,vdpa,qemu_fw_cfg: features, cleanups, fixes	2022-01-18 10:05:48 +02:00
nvme	nvmet: revert "nvmet: make discovery NQN configurable"	2022-03-15 10:39:26 +01:00
nvmem	nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property	2022-02-21 17:59:25 +01:00
of	of/fdt: move elfcorehdr reservation early for crash dump kernel	2022-02-17 17:13:52 -06:00
opp
parisc	parisc: Fix sglist access in ccio-dma.c	2022-01-28 10:15:34 +01:00
parport
pci	A single fix for a regression caused by the recent PCI/MSI rework which	2022-02-27 13:07:40 -08:00
pcmcia	pci-v5.17-changes	2022-01-16 08:08:11 +02:00
perf	Rework of the MSI interrupt infrastructure:	2022-01-13 09:05:29 -08:00
phy	phy: dphy: Correct clk_pre parameter	2022-02-02 10:33:04 +05:30
pinctrl	pinctrl: sunxi: Use unique lockdep classes for IRQs	2022-02-28 23:53:19 +01:00
platform	surface: surface3_power: Fix battery readings on batteries without a serial number	2022-02-24 13:48:39 +01:00
pnp	proc: remove PDE_DATA() completely	2022-01-22 08:33:37 +02:00
power	power: supply: bq256xx: Handle OOM correctly	2022-02-11 21:19:51 +01:00
powercap
pps
ps3
ptp	ptp: ocp: Add ptp_ocp_adjtime_coarse for large adjustments	2022-03-02 09:51:21 -08:00
pwm	pwm: Changes for v5.17-rc1	2022-01-20 13:25:01 +02:00
rapidio
ras
regulator	regulator: da9121: Remove surplus DA9141 parameters	2022-02-22 11:56:29 +00:00
remoteproc	remoteproc: qcom: q6v5: fix service routines build errors	2022-01-17 16:44:26 -06:00
reset	SoC: Add support for StarFive JH7100 RISC-V SoC	2022-01-10 08:32:37 -08:00
rpmsg	rpmsg fixes for v5.17-rc1	2022-01-27 11:23:26 +02:00
rtc	rtc: sunplus: fix return value in sp_rtc_probe()	2022-01-16 23:50:34 +01:00
s390	s390/cio: verify the driver availability for path_event call	2022-02-09 22:55:01 +01:00
sbus
scsi	SCSI fixes on 20220319	2022-03-19 15:56:43 -07:00
sh
siox
slimbus
soc	ARM: SoC fixes for 5.17, part 3	2022-03-10 11:43:01 -08:00
soundwire	Char/Misc and other driver changes for 5.17-rc1	2022-01-14 16:02:28 +01:00
spi	spi: Fix for v5.17	2022-03-10 04:15:09 -08:00
spmi
ssb
staging	staging: rtl8723bs: Improve the comment explaining the locking rules	2022-03-02 16:38:24 +01:00
target	scsi: target: iscsi: Make sure the np under each tpg is unique	2022-01-24 23:30:24 -05:00
tc
tee	OP-TEE fix error return code in probe functions	2022-02-18 17:30:01 +01:00
thermal	thermal: core: Fix TZ_GET_TRIP NULL pointer dereference	2022-03-01 16:11:38 +01:00
thunderbolt
tty	TTY/Serial driver fixes for 5.17-rc6	2022-02-25 11:45:29 -08:00
uio
usb	USB fixes for 5.17	2022-03-19 10:16:33 -07:00
vdpa	vdpa: fix use-after-free on vp_vdpa_remove	2022-03-06 06:06:50 -05:00
vfio	VFIO updates for v5.17-rc1	2022-01-20 13:31:46 +02:00
vhost	Networking fixes for 5.17-final, including fixes from netfilter, ipsec,	2022-03-17 12:55:26 -07:00
video	* drm/panel: simple: Fix assignments from panel_dpi_probe()	2022-02-11 12:06:15 +10:00
virt	bitmap patches for 5.17-rc1	2022-01-23 06:20:44 +02:00
virtio	virtio: drop default for virtio-mem	2022-03-06 06:06:50 -05:00
visorbus
vlynq
vme
w1
watchdog	linux-watchdog 5.17-rc1 tag	2022-01-17 08:07:57 +02:00
xen	xen/gnttab: fix gnttab_end_foreign_access() without page specified	2022-03-07 09:48:55 +01:00
zorro	proc: remove PDE_DATA() completely	2022-01-22 08:33:37 +02:00
Kconfig
Makefile