TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
bd3ec28fb6d985ee377efe018e2ff8cf7dfce902
twx-linux/net/netfilter
T
History
Vasily Averin d7d62156f4 netfilter: x_tables: gpf inside xt_find_revision() 
commit 8e24edddad upstream.

nested target/match_revfn() calls work with xt[NFPROTO_UNSPEC] lists
without taking xt[NFPROTO_UNSPEC].mutex. This can race with module unload
and cause host to crash:

general protection fault: 0000 [#1]
Modules linked in: ... [last unloaded: xt_cluster]
CPU: 0 PID: 542455 Comm: iptables
RIP: 0010:[<ffffffff8ffbd518>]  [<ffffffff8ffbd518>] strcmp+0x18/0x40
RDX: 0000000000000003 RSI: ffff9a5a5d9abe10 RDI: dead000000000111
R13: ffff9a5a5d9abe10 R14: ffff9a5a5d9abd8c R15: dead000000000100
(VvS: %R15 -- &xt_match,  %RDI -- &xt_match.name,
xt_cluster unregister match in xt[NFPROTO_UNSPEC].match list)
Call Trace:
 [<ffffffff902ccf44>] match_revfn+0x54/0xc0
 [<ffffffff902ccf9f>] match_revfn+0xaf/0xc0
 [<ffffffff902cd01e>] xt_find_revision+0x6e/0xf0
 [<ffffffffc05a5be0>] do_ipt_get_ctl+0x100/0x420 [ip_tables]
 [<ffffffff902cc6bf>] nf_getsockopt+0x4f/0x70
 [<ffffffff902dd99e>] ip_getsockopt+0xde/0x100
 [<ffffffff903039b5>] raw_getsockopt+0x25/0x50
 [<ffffffff9026c5da>] sock_common_getsockopt+0x1a/0x20
 [<ffffffff9026b89d>] SyS_getsockopt+0x7d/0xf0
 [<ffffffff903cbf92>] system_call_fastpath+0x25/0x2a

Fixes: 656caff20e ("netfilter 04/09: x_tables: fix match/target revision lookup")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-03-17 16:10:13 +01:00
..
ipset
netfilter: ipset: fix shift-out-of-bounds in htable_bits()
2021-01-12 19:49:05 +01:00
ipvs
ipvs: Fix uninit-value in do_ip_vs_set_ctl()
2020-10-29 09:05:45 +01:00
core.c
…
Kconfig
…
Makefile
…
nf_conntrack_acct.c
…
nf_conntrack_amanda.c
…
nf_conntrack_broadcast.c
…
nf_conntrack_core.c
netfilter: conntrack: skip identical origin tuple in same zone only
2021-02-23 13:59:16 +01:00
nf_conntrack_ecache.c
…
nf_conntrack_expect.c
…
nf_conntrack_extend.c
…
nf_conntrack_ftp.c
netfilter: nf_conntrack_ftp: Fix debug output
2019-09-21 07:14:16 +02:00
nf_conntrack_h323_asn1.c
…
nf_conntrack_h323_main.c
netfilter: nf_conntrack_h323: lost .data_len definition for Q.931/ipv6
2020-07-09 09:35:57 +02:00
nf_conntrack_h323_types.c
…
nf_conntrack_helper.c
…
nf_conntrack_irc.c
…
nf_conntrack_l3proto_generic.c
…
nf_conntrack_labels.c
…
nf_conntrack_netbios_ns.c
…
nf_conntrack_netlink.c
netfilter: ctnetlink: add a range check for l3/l4 protonum
2020-10-14 09:48:14 +02:00
nf_conntrack_pptp.c
netfilter: nf_conntrack_pptp: fix compilation warning with W=1 build
2020-06-03 08:16:46 +02:00
nf_conntrack_proto_dccp.c
netfilter: conntrack: dccp: treat SYNC/SYNCACK as invalid if no prior state
2018-08-24 13:12:41 +02:00
nf_conntrack_proto_generic.c
…
nf_conntrack_proto_gre.c
…
nf_conntrack_proto_sctp.c
…
nf_conntrack_proto_tcp.c
…
nf_conntrack_proto_udp.c
…
nf_conntrack_proto_udplite.c
…
nf_conntrack_proto.c
…
nf_conntrack_sane.c
…
nf_conntrack_seqadj.c
netfilter: seqadj: re-load tcp header pointer after possible head reallocation
2019-01-13 10:03:48 +01:00
nf_conntrack_sip.c
…
nf_conntrack_snmp.c
…
nf_conntrack_standalone.c
netfilter: conntrack: fix reading nf_conntrack_buckets
2021-01-23 15:38:18 +01:00
nf_conntrack_tftp.c
…
nf_conntrack_timeout.c
…
nf_conntrack_timestamp.c
…
nf_dup_netdev.c
…
nf_internals.h
…
nf_log_common.c
…
nf_log.c
…
nf_nat_amanda.c
…
nf_nat_core.c
netfilter: check for seqadj ext existence before adding it in nf_nat_setup_info
2018-10-20 09:51:32 +02:00
nf_nat_ftp.c
…
nf_nat_helper.c
…
nf_nat_irc.c
…
nf_nat_proto_common.c
…
nf_nat_proto_dccp.c
…
nf_nat_proto_sctp.c
…
nf_nat_proto_tcp.c
…
nf_nat_proto_udp.c
…
nf_nat_proto_udplite.c
…
nf_nat_proto_unknown.c
…
nf_nat_redirect.c
…
nf_nat_sip.c
…
nf_nat_tftp.c
…
nf_queue.c
…
nf_sockopt.c
…
nf_synproxy_core.c
…
nf_tables_api.c
netfilter: nf_tables: add NFTA_SET_USERDATA if not null
2020-09-12 11:47:33 +02:00
nf_tables_core.c
…
nf_tables_inet.c
…
nf_tables_netdev.c
…
nf_tables_trace.c
…
nfnetlink_acct.c
…
nfnetlink_cthelper.c
netfilter: cthelper: add missing attribute validation for cthelper
2020-03-20 09:07:46 +01:00
nfnetlink_cttimeout.c
…
nfnetlink_log.c
…
nfnetlink_queue.c
…
nfnetlink.c
netfilter: nfnetlink: avoid deadlock due to synchronous request_module
2019-08-25 10:51:22 +02:00
nft_bitwise.c
…
nft_byteorder.c
…
nft_cmp.c
…
nft_compat.c
…
nft_counter.c
…
nft_ct.c
netfilter: nf_tables: fix mismatch in big-endian system
2019-02-20 10:18:34 +01:00
nft_dup_netdev.c
…
nft_dynset.c
netfilter: nft_dynset: add timeout extension to template
2021-02-03 23:19:51 +01:00
nft_exthdr.c
…
nft_fwd_netdev.c
netfilter: nft_fwd_netdev: validate family and chain type
2020-04-02 17:20:35 +02:00
nft_hash.c
…
nft_immediate.c
…
nft_limit.c
…
nft_log.c
…
nft_lookup.c
…
nft_masq.c
…
nft_meta.c
netfilter: nf_tables: fix mismatch in big-endian system
2019-02-20 10:18:34 +01:00
nft_nat.c
netfilter: nft_nat: return EOPNOTSUPP if type or flags are not supported
2020-06-20 10:24:15 +02:00
nft_numgen.c
…
nft_payload.c
netfilter: nf_tables: fix destination register zeroing
2020-09-12 11:47:33 +02:00
nft_queue.c
…
nft_quota.c
…
nft_range.c
…
nft_redir.c
…
nft_reject_inet.c
…
nft_reject.c
…
nft_set_hash.c
…
nft_set_rbtree.c
netfilter: nft_set_rbtree: check for inactive element after flag mismatch
2019-05-04 08:49:06 +02:00
x_tables.c
netfilter: x_tables: gpf inside xt_find_revision()
2021-03-17 16:10:13 +01:00
xt_addrtype.c
…
xt_AUDIT.c
…
xt_bpf.c
netfilter: xt_bpf: add overflow checks
2020-02-28 15:42:51 +01:00
xt_cgroup.c
…
xt_CHECKSUM.c
…
xt_CLASSIFY.c
…
xt_cluster.c
…
xt_comment.c
…
xt_connbytes.c
…
xt_connlabel.c
…
xt_connlimit.c
…
xt_connmark.c
…
xt_CONNSECMARK.c
…
xt_conntrack.c
…
xt_cpu.c
…
xt_CT.c
…
xt_dccp.c
…
xt_devgroup.c
…
xt_dscp.c
…
xt_DSCP.c
…
xt_ecn.c
…
xt_esp.c
…
xt_hashlimit.c
netfilter: xt_hashlimit: limit the max size of hashtable
2020-02-28 15:42:56 +01:00
xt_helper.c
…
xt_hl.c
…
xt_HL.c
…
xt_HMARK.c
…
xt_IDLETIMER.c
netfilter: xt_IDLETIMER: add sysfs filename checking routine
2018-11-27 16:09:39 +01:00
xt_ipcomp.c
…
xt_iprange.c
…
xt_ipvs.c
…
xt_l2tp.c
…
xt_LED.c
…
xt_length.c
…
xt_limit.c
…
xt_LOG.c
…
xt_mac.c
…
xt_mark.c
…
xt_multiport.c
…
xt_nat.c
…
xt_NETMAP.c
…
xt_nfacct.c
…
xt_NFLOG.c
…
xt_NFQUEUE.c
…
xt_osf.c
…
xt_owner.c
…
xt_physdev.c
netfilter: physdev: relax br_netfilter dependency
2019-04-05 22:29:14 +02:00
xt_pkttype.c
…
xt_policy.c
…
xt_quota.c
…
xt_rateest.c
…
xt_RATEEST.c
netfilter: xt_RATEEST: reject non-null terminated string from userspace
2021-01-12 19:49:05 +01:00
xt_realm.c
…
xt_recent.c
netfilter: xt_recent: Fix attempt to update deleted entry
2021-02-23 13:59:16 +01:00
xt_REDIRECT.c
…
xt_repldata.h
…
xt_sctp.c
…
xt_SECMARK.c
…
xt_set.c
…
xt_socket.c
…
xt_state.c
…
xt_statistic.c
…
xt_string.c
…
xt_tcpmss.c
…
xt_TCPMSS.c
…
xt_TCPOPTSTRIP.c
…
xt_tcpudp.c
…
xt_TEE.c
…
xt_time.c
…
xt_TPROXY.c
…
xt_TRACE.c
…
xt_u32.c
…