TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
94e5a12759552aa60d6576f773d0e7a9242594de
twx-linux/net/netfilter
T
History
Vasily Averin c1f486e1a9 netfilter: ctnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo 
commit c23a9fd209 upstream.

Two patches listed below removed ctnetlink_dump_helpinfo call from under
rcu_read_lock. Now its rcu_dereference generates following warning:
=============================
WARNING: suspicious RCU usage
5.13.0+ #5 Not tainted
-----------------------------
net/netfilter/nf_conntrack_netlink.c:221 suspicious rcu_dereference_check() usage!

other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
stack backtrace:
CPU: 1 PID: 2251 Comm: conntrack Not tainted 5.13.0+ #5
Call Trace:
 dump_stack+0x7f/0xa1
 ctnetlink_dump_helpinfo+0x134/0x150 [nf_conntrack_netlink]
 ctnetlink_fill_info+0x2c2/0x390 [nf_conntrack_netlink]
 ctnetlink_dump_table+0x13f/0x370 [nf_conntrack_netlink]
 netlink_dump+0x10c/0x370
 __netlink_dump_start+0x1a7/0x260
 ctnetlink_get_conntrack+0x1e5/0x250 [nf_conntrack_netlink]
 nfnetlink_rcv_msg+0x613/0x993 [nfnetlink]
 netlink_rcv_skb+0x50/0x100
 nfnetlink_rcv+0x55/0x120 [nfnetlink]
 netlink_unicast+0x181/0x260
 netlink_sendmsg+0x23f/0x460
 sock_sendmsg+0x5b/0x60
 __sys_sendto+0xf1/0x160
 __x64_sys_sendto+0x24/0x30
 do_syscall_64+0x36/0x70
 entry_SYSCALL_64_after_hwframe+0x44/0xae

Fixes: 49ca022bcc ("netfilter: ctnetlink: don't dump ct extensions of unconfirmed conntracks")
Fixes: 0b35f6031a ("netfilter: Remove duplicated rcu_read_lock.")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-28 11:12:15 +02:00
..
ipset
netfilter: ipset: fix shift-out-of-bounds in htable_bits()
2021-01-12 20:09:14 +01:00
ipvs
ipvs: ignore IP_VS_SVC_F_HASHED flag when adding service
2021-06-10 12:43:50 +02:00
core.c
…
Kconfig
…
Makefile
…
nf_conntrack_acct.c
…
nf_conntrack_amanda.c
…
nf_conntrack_broadcast.c
…
nf_conntrack_core.c
netfilter: conntrack: skip identical origin tuple in same zone only
2021-02-23 14:00:32 +01:00
nf_conntrack_ecache.c
…
nf_conntrack_expect.c
…
nf_conntrack_extend.c
…
nf_conntrack_ftp.c
…
nf_conntrack_h323_asn1.c
…
nf_conntrack_h323_main.c
…
nf_conntrack_h323_types.c
…
nf_conntrack_helper.c
…
nf_conntrack_irc.c
…
nf_conntrack_l3proto_generic.c
…
nf_conntrack_labels.c
…
nf_conntrack_netbios_ns.c
…
nf_conntrack_netlink.c
netfilter: ctnetlink: suspicious RCU usage in ctnetlink_dump_helpinfo
2021-07-28 11:12:15 +02:00
nf_conntrack_pptp.c
netfilter: nf_conntrack_pptp: fix compilation warning with W=1 build
2020-06-03 08:18:10 +02:00
nf_conntrack_proto_dccp.c
…
nf_conntrack_proto_generic.c
…
nf_conntrack_proto_gre.c
…
nf_conntrack_proto_sctp.c
…
nf_conntrack_proto_tcp.c
…
nf_conntrack_proto_udp.c
…
nf_conntrack_proto.c
…
nf_conntrack_sane.c
…
nf_conntrack_seqadj.c
…
nf_conntrack_sip.c
…
nf_conntrack_snmp.c
…
nf_conntrack_standalone.c
netfilter: conntrack: Make global sysctls readonly in non-init netns
2021-05-22 10:57:41 +02:00
nf_conntrack_tftp.c
…
nf_conntrack_timeout.c
…
nf_conntrack_timestamp.c
…
nf_dup_netdev.c
…
nf_internals.h
…
nf_log_common.c
…
nf_log_netdev.c
…
nf_log.c
…
nf_nat_amanda.c
…
nf_nat_core.c
…
nf_nat_ftp.c
…
nf_nat_helper.c
…
nf_nat_irc.c
…
nf_nat_proto_common.c
…
nf_nat_proto_dccp.c
…
nf_nat_proto_sctp.c
…
nf_nat_proto_tcp.c
…
nf_nat_proto_udp.c
netfilter: nat: never update the UDP checksum when it's 0
2020-05-20 08:17:01 +02:00
nf_nat_proto_unknown.c
…
nf_nat_redirect.c
…
nf_nat_sip.c
…
nf_nat_tftp.c
…
nf_queue.c
netfilter: nf_queue: enqueue skbs with NULL dst
2020-01-04 13:59:59 +01:00
nf_sockopt.c
…
nf_synproxy_core.c
netfilter: synproxy: Fix out of bounds when parsing TCP options
2021-06-30 08:48:49 -04:00
nf_tables_api.c
netfilter: nf_tables: add NFTA_SET_USERDATA if not null
2020-09-09 19:03:08 +02:00
nf_tables_core.c
…
nf_tables_inet.c
…
nf_tables_netdev.c
…
nf_tables_trace.c
…
nfnetlink_acct.c
…
nfnetlink_cthelper.c
netfilter: nfnetlink_cthelper: hit EBUSY on updates if size mismatches
2021-06-10 12:43:50 +02:00
nfnetlink_cttimeout.c
…
nfnetlink_log.c
…
nfnetlink_queue.c
…
nfnetlink.c
…
nft_bitwise.c
…
nft_byteorder.c
…
nft_cmp.c
…
nft_compat.c
netfilter: nft_compat: do not dump private area
2019-11-24 08:23:32 +01:00
nft_counter.c
…
nft_ct.c
…
nft_dup_netdev.c
…
nft_dynset.c
netfilter: nft_dynset: add timeout extension to template
2021-02-03 23:22:22 +01:00
nft_exthdr.c
netfilter: nft_exthdr: check for IPv6 packet before further processing
2021-07-20 16:17:36 +02:00
nft_fib_inet.c
…
nft_fib_netdev.c
…
nft_fib.c
…
nft_fwd_netdev.c
netfilter: nft_fwd_netdev: validate family and chain type
2020-04-02 16:34:32 +02:00
nft_hash.c
…
nft_immediate.c
…
nft_limit.c
netfilter: nft_limit: avoid possible divide error in nft_limit_init
2021-04-28 12:08:42 +02:00
nft_log.c
…
nft_lookup.c
netfilter: nf_tables: allow lookups in dynamic sets
2019-10-11 18:18:39 +02:00
nft_masq.c
…
nft_meta.c
…
nft_nat.c
netfilter: nft_nat: return EOPNOTSUPP if type or flags are not supported
2020-06-20 10:25:10 +02:00
nft_numgen.c
…
nft_objref.c
…
nft_payload.c
netfilter: nf_tables: fix destination register zeroing
2020-09-09 19:03:08 +02:00
nft_queue.c
…
nft_quota.c
…
nft_range.c
…
nft_redir.c
…
nft_reject_inet.c
…
nft_reject.c
…
nft_rt.c
…
nft_set_bitmap.c
…
nft_set_hash.c
netfilter: nftables: avoid overflows in nft_hash_buckets()
2021-05-22 10:57:39 +02:00
nft_set_rbtree.c
…
x_tables.c
netfilter: x_tables: Use correct memory barriers.
2021-06-03 08:36:11 +02:00
xt_addrtype.c
…
xt_AUDIT.c
…
xt_bpf.c
…
xt_cgroup.c
…
xt_CHECKSUM.c
…
xt_CLASSIFY.c
…
xt_cluster.c
…
xt_comment.c
…
xt_connbytes.c
…
xt_connlabel.c
…
xt_connlimit.c
…
xt_connmark.c
…
xt_CONNSECMARK.c
…
xt_conntrack.c
…
xt_cpu.c
…
xt_CT.c
…
xt_dccp.c
…
xt_devgroup.c
…
xt_dscp.c
…
xt_DSCP.c
…
xt_ecn.c
…
xt_esp.c
…
xt_hashlimit.c
netfilter: xt_hashlimit: limit the max size of hashtable
2020-02-28 16:36:16 +01:00
xt_helper.c
…
xt_hl.c
…
xt_HL.c
…
xt_HMARK.c
…
xt_IDLETIMER.c
…
xt_ipcomp.c
…
xt_iprange.c
…
xt_ipvs.c
…
xt_l2tp.c
…
xt_LED.c
…
xt_length.c
…
xt_limit.c
…
xt_LOG.c
…
xt_mac.c
…
xt_mark.c
…
xt_multiport.c
…
xt_nat.c
…
xt_NETMAP.c
…
xt_nfacct.c
…
xt_NFLOG.c
…
xt_NFQUEUE.c
…
xt_osf.c
…
xt_owner.c
…
xt_physdev.c
…
xt_pkttype.c
…
xt_policy.c
…
xt_quota.c
…
xt_rateest.c
…
xt_RATEEST.c
netfilter: xt_RATEEST: reject non-null terminated string from userspace
2021-01-12 20:09:14 +01:00
xt_realm.c
…
xt_recent.c
netfilter: xt_recent: Fix attempt to update deleted entry
2021-02-23 14:00:32 +01:00
xt_REDIRECT.c
…
xt_repldata.h
…
xt_sctp.c
…
xt_SECMARK.c
…
xt_set.c
…
xt_socket.c
…
xt_state.c
…
xt_statistic.c
…
xt_string.c
…
xt_tcpmss.c
…
xt_TCPMSS.c
…
xt_TCPOPTSTRIP.c
…
xt_tcpudp.c
…
xt_TEE.c
…
xt_time.c
…
xt_TPROXY.c
…
xt_TRACE.c
…
xt_u32.c
…