Jiri Pirko 89875151fc virtio: delete vq in vp_find_vqs_msix() when request_irq() fails ... When request_irq() fails, error path calls vp_del_vqs(). There, as vq is present in the list, free_irq() is called for the same vector. That causes following splat: [ 0.414355] Trying to free already-free IRQ 27 [ 0.414403] WARNING: CPU: 1 PID: 1 at kernel/irq/manage.c:1899 free_irq+0x1a1/0x2d0 [ 0.414510] Modules linked in: [ 0.414540] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc4+ #27 [ 0.414540] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-1.fc39 04/01/2014 [ 0.414540] RIP: 0010:free_irq+0x1a1/0x2d0 [ 0.414540] Code: 1e 00 48 83 c4 08 48 89 e8 5b 5d 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc 90 8b 74 24 04 48 c7 c7 98 80 6c b1 e8 00 c9 f7 ff 90 <0f> 0b 90 90 48 89 ee 4c 89 ef e8 e0 20 b8 00 49 8b 47 40 48 8b 40 [ 0.414540] RSP: 0000:ffffb71480013ae0 EFLAGS: 00010086 [ 0.414540] RAX: 0000000000000000 RBX: ffffa099c2722000 RCX: 0000000000000000 [ 0.414540] RDX: 0000000000000000 RSI: ffffb71480013998 RDI: 0000000000000001 [ 0.414540] RBP: 0000000000000246 R08: 00000000ffffdfff R09: 0000000000000001 [ 0.414540] R10: 00000000ffffdfff R11: ffffffffb18729c0 R12: ffffa099c1c91760 [ 0.414540] R13: ffffa099c1c916a4 R14: ffffa099c1d2f200 R15: ffffa099c1c91600 [ 0.414540] FS: 0000000000000000(0000) GS:ffffa099fec40000(0000) knlGS:0000000000000000 [ 0.414540] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.414540] CR2: 0000000000000000 CR3: 0000000008e3e001 CR4: 0000000000370ef0 [ 0.414540] Call Trace: [ 0.414540] <TASK> [ 0.414540] ? __warn+0x80/0x120 [ 0.414540] ? free_irq+0x1a1/0x2d0 [ 0.414540] ? report_bug+0x164/0x190 [ 0.414540] ? handle_bug+0x3b/0x70 [ 0.414540] ? exc_invalid_op+0x17/0x70 [ 0.414540] ? asm_exc_invalid_op+0x1a/0x20 [ 0.414540] ? free_irq+0x1a1/0x2d0 [ 0.414540] vp_del_vqs+0xc1/0x220 [ 0.414540] vp_find_vqs_msix+0x305/0x470 [ 0.414540] vp_find_vqs+0x3e/0x1a0 [ 0.414540] vp_modern_find_vqs+0x1b/0x70 [ 0.414540] init_vqs+0x387/0x600 [ 0.414540] virtnet_probe+0x50a/0xc80 [ 0.414540] virtio_dev_probe+0x1e0/0x2b0 [ 0.414540] really_probe+0xc0/0x2c0 [ 0.414540] ? __pfx___driver_attach+0x10/0x10 [ 0.414540] __driver_probe_device+0x73/0x120 [ 0.414540] driver_probe_device+0x1f/0xe0 [ 0.414540] __driver_attach+0x88/0x180 [ 0.414540] bus_for_each_dev+0x85/0xd0 [ 0.414540] bus_add_driver+0xec/0x1f0 [ 0.414540] driver_register+0x59/0x100 [ 0.414540] ? __pfx_virtio_net_driver_init+0x10/0x10 [ 0.414540] virtio_net_driver_init+0x90/0xb0 [ 0.414540] do_one_initcall+0x58/0x230 [ 0.414540] kernel_init_freeable+0x1a3/0x2d0 [ 0.414540] ? __pfx_kernel_init+0x10/0x10 [ 0.414540] kernel_init+0x1a/0x1c0 [ 0.414540] ret_from_fork+0x31/0x50 [ 0.414540] ? __pfx_kernel_init+0x10/0x10 [ 0.414540] ret_from_fork_asm+0x1a/0x30 [ 0.414540] </TASK> Fix this by calling deleting the current vq when request_irq() fails. Fixes: 0b0f9dc52ed0 ("Revert "virtio_pci: use shared interrupts for virtqueues"") Signed-off-by: Jiri Pirko <jiri@nvidia.com> Message-Id: <20240426150845.3999481-1-jiri@resnulli.us> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>		2024-05-22 08:31:38 -04:00
..
accel	accel/ivpu: Fix deadlock in context_xa	2024-04-08 10:55:01 +02:00
accessibility	speakup: Avoid crash on very long word	2024-04-11 14:32:53 +02:00
acpi	Merge branch 'acpi-cppc'	2024-04-25 19:25:54 +02:00
amba
android	binder: check offset alignment in binder_get_object()	2024-04-11 15:19:12 +02:00
ata	ata: libata-core: Allow command duration limits detection for ACS-4 drives	2024-04-13 10:42:28 +09:00
atm
auxdisplay	auxdisplay: img-ascii-lcd: Convert to platform remove callback returning void	2024-03-12 17:37:54 +02:00
base	regmap: Fixes for v6.9	2024-04-05 17:21:16 -07:00
bcma
block	virtio_blk: drop owner assignment	2024-05-22 08:31:16 -04:00
bluetooth	bluetooth: virtio: drop owner assignment	2024-05-22 08:31:16 -04:00
bus	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
cache	cache: sifive_ccache: Partially convert to a platform driver	2024-03-28 22:40:56 +00:00
cdrom
cdx
char	virtio_console: drop owner assignment	2024-05-22 08:31:16 -04:00
clk	clk: mediatek: mt7988-infracfg: fix clocks for 2nd PCIe port	2024-04-10 20:50:26 -07:00
clocksource	A set of updates for clocksource and clockevent drivers:	2024-03-23 14:42:45 -07:00
comedi	comedi: vmk80xx: fix incomplete endpoint checking	2024-04-11 15:16:23 +02:00
connector
counter
cpufreq	RISC-V Patches for the 6.9 Merge Window	2024-03-22 10:41:13 -07:00
cpuidle	RISC-V Patches for the 6.9 Merge Window	2024-03-22 10:41:13 -07:00
crypto	crypto: virtio - drop owner assignment	2024-05-22 08:31:16 -04:00
cxl	cxl/core: Fix potential payload size confusion in cxl_mem_get_poison()	2024-04-22 08:58:59 -07:00
dax	libnvdimm updates for v6.9	2024-03-15 11:58:32 -07:00
dca
devfreq
dio
dma	dmaengine: idxd: Fix oops during rmmod on single-CPU platforms	2024-04-07 17:56:06 +05:30
dma-buf	Merge drm/drm-fixes into drm-misc-fixes	2024-03-25 21:11:58 +01:00
dpll	dpll: fix dpll_pin_on_pin_register() for multiple parent pins	2024-04-25 08:32:09 -07:00
edac	- Add a FRU (Field Replaceable Unit) memory poison manager which	2024-03-11 18:14:06 -07:00
eisa
extcon
firewire	firewire: ohci: mask bus reset interrupts between ISR and bottom half	2024-04-06 09:36:46 +09:00
firmware	firmware: arm_scmi: virtio: drop owner assignment	2024-05-22 08:31:17 -04:00
fpga	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
fsi
gnss
gpio	gpio: virtio: drop owner assignment	2024-05-22 08:31:17 -04:00
gpu	drm/virtio: drop owner assignment	2024-05-22 08:31:17 -04:00
greybus	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
hid	HID: mcp-2221: cancel delayed_work only when CONFIG_IIO is enabled	2024-04-12 17:48:53 +02:00
hsi
hte
hv	hyperv-fixes for v6.9-rc4	2024-04-11 16:23:56 -07:00
hwmon	- Kuan-Wei Chiu has developed the well-named series "lib min_heap: Min	2024-03-14 18:03:09 -07:00
hwspinlock
hwtracing
i2c	i2c: smbus: fix NULL function pointer dereference	2024-04-27 12:57:57 +02:00
i3c
idle
iio	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
infiniband	RDMA/mlx5: Fix port number for counter query in multi-port configuration	2024-04-08 13:33:10 +03:00
input	TTY/Serial driver update for 6.9-rc1	2024-03-21 12:44:10 -07:00
interconnect	interconnect fixes for v6.9-rc	2024-04-11 14:44:49 +02:00
iommu	iommu: virtio: drop owner assignment	2024-05-22 08:31:17 -04:00
ipack
irqchip	irqchip/gic-v3-its: Prevent double free on error	2024-04-25 14:30:46 +02:00
isdn	mISDN: fix MISDN_TIME_STAMP handling	2024-04-09 17:01:01 -07:00
leds	- Kuan-Wei Chiu has developed the well-named series "lib min_heap: Min	2024-03-14 18:03:09 -07:00
macintosh	powerpc updates for 6.9	2024-03-15 17:53:48 -07:00
mailbox	imx: add support for i.MX95 ELE/V2X MU	2024-03-13 12:23:36 -07:00
mcb
md	- Fix 6.9 regression so that DM device removal is performed	2024-04-26 11:17:24 -07:00
media	media: mediatek: vcodec: support 36 bits physical address	2024-03-26 09:52:59 +01:00
memory	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
memstick	MMC core:	2024-03-13 10:59:28 -07:00
message
mfd	TTY/Serial driver update for 6.9-rc1	2024-03-21 12:44:10 -07:00
misc	misc: nsm: drop owner assignment	2024-05-22 08:31:17 -04:00
mmc	MMC host:	2024-04-26 13:17:33 -07:00
most
mtd	There has been OTP support improvements in the NVMEM subsystem, and	2024-04-26 13:05:34 -07:00
mux
net	wifi: mac80211_hwsim: drop owner assignment	2024-05-22 08:31:18 -04:00
nfc	NFC: trf7970a: disable all regulators on removal	2024-04-22 14:19:58 -07:00
ntb
nubus
nvdimm	nvdimm: virtio_pmem: drop owner assignment	2024-05-22 08:31:18 -04:00
nvme	nvme-fc: rename free_ctrl callback to match name pattern	2024-04-04 08:47:56 -07:00
nvmem
of	of: module: prevent NULL pointer dereference in vsnprintf()	2024-03-27 17:05:07 -05:00
opp	OPP: Extend dev_pm_opp_data with turbo support	2024-03-11 10:39:24 +05:30
parisc
parport
pci	Revert "PCI: Mark LSI FW643 to avoid bus reset"	2024-03-29 11:57:12 -05:00
pcmcia
peci
perf	drivers/perf: riscv: Disable PERF_SAMPLE_BRANCH_* while not supported	2024-03-26 14:09:18 -07:00
phy	phy: ti: tusb1210: Resolve charger-det crash if charger psy is unregistered	2024-04-12 16:57:19 +05:30
pinctrl	Pin control fixes for the v6.9 series:	2024-04-30 08:50:58 -07:00
platform	platform-drivers-x86 for v6.9-4	2024-04-30 09:06:05 -07:00
pmdomain	Core:	2024-03-13 11:33:10 -07:00
pnp
power	power: supply: mt6360_charger: Fix of_match for usb-otg-vbus regulator	2024-04-15 13:31:37 +02:00
powercap	powercap: intel_rapl: Convert to platform remove callback returning void	2024-03-13 20:45:54 +01:00
pps
ps3
ptp	Networking changes for 6.9.	2024-03-12 17:44:08 -07:00
pwm	pwm: dwc: allow suspend/resume for 16 channels	2024-04-15 17:28:13 +02:00
rapidio
ras	RAS: Avoid build errors when CONFIG_DEBUG_FS=n	2024-03-26 21:48:21 +01:00
regulator	regulator: tps65132: Add of_match table	2024-03-25 19:28:27 +00:00
remoteproc	remoteproc updates for v6.9	2024-03-21 10:37:39 -07:00
reset
rpmsg	rpmsg: virtio: drop owner assignment	2024-05-22 08:31:18 -04:00
rtc	RTC for 6.9	2024-03-21 17:16:46 -07:00
s390	s390 updates for 6.9-rc5	2024-04-19 09:59:15 -07:00
sbus	This includes the following changes related to sparc for v6.9:	2024-03-15 12:47:21 -07:00
scsi	scsi: virtio: drop owner assignment	2024-05-22 08:31:18 -04:00
sh
siox	SIOX changes for 6.9-rc1	2024-03-21 15:18:18 -07:00
slimbus
soc	soc: mediatek: mtk-socinfo: depends on CONFIG_SOC_BUS	2024-04-23 12:09:12 +02:00
soundwire	soundwire: amd: fix for wake interrupt handling for clockstop mode	2024-03-28 23:40:33 +05:30
spi	spi: mchp-pci1xxx: Fix a possible null pointer dereference in pci1xxx_spi_probe	2024-04-03 11:04:58 +01:00
spmi
ssb
staging	staging: vc04_services: fix information leak in create_component()	2024-03-25 19:10:01 +01:00
target	scsi: target: Fix SELinux error when systemd-modules loads the target module	2024-04-05 21:37:54 -04:00
tc
tee	ARM: SoC drivers for 6.9	2024-03-12 10:35:24 -07:00
thermal	thermal/debugfs: Add missing count increment to thermal_debug_tz_trip_up()	2024-04-19 15:08:19 +02:00
thunderbolt	thunderbolt: Avoid notify PM core about runtime PM resume	2024-04-10 10:49:58 +03:00
tty	serial: stm32: Reset .throttled state in .startup()	2024-04-17 13:26:45 +02:00
ufs	scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5	2024-04-08 15:06:56 -04:00
uio	hyperv-fixes for v6.9-rc4	2024-04-11 16:23:56 -07:00
usb	USB-serial device ids for 6.9-rc5	2024-04-19 16:07:18 +02:00
vdpa	vp_vdpa: don't allocate unused msix vectors	2024-05-22 08:31:18 -04:00
vfio	VFIO updates for v6.9-rc1	2024-03-15 13:21:13 -07:00
vhost	vhost-vdpa: Remove usage of the deprecated ida_simple_xx() API	2024-05-22 08:31:18 -04:00
video	fbdev: fix incorrect address computation in deferred IO	2024-04-24 15:03:37 +02:00
virt	Revert "vmgenid: emit uevent when VMGENID updates"	2024-04-18 14:47:23 +02:00
virtio	virtio: delete vq in vp_find_vqs_msix() when request_irq() fails	2024-05-22 08:31:38 -04:00
w1
watchdog	linux-watchdog 6.9-rc1 tag	2024-03-17 12:06:10 -07:00
xen	xen: branch for v6.9-rc1	2024-03-19 08:48:09 -07:00
zorro
Kconfig
Makefile