Files
twx-linux/include/linux
Danilo Krummrich b2708e1e30 usb: quirks: add control message delay for 1b1c:1b20
commit cb88a05887 upstream.

Corsair Strafe RGB keyboard does not respond to usb control messages
sometimes and hence generates timeouts.

Commit de3af5bf25 ("usb: quirks: add delay init quirk for Corsair
Strafe RGB keyboard") tried to fix those timeouts by adding
USB_QUIRK_DELAY_INIT.

Unfortunately, even with this quirk timeouts of usb_control_msg()
can still be seen, but with a lower frequency (approx. 1 out of 15):

[   29.103520] usb 1-8: string descriptor 0 read error: -110
[   34.363097] usb 1-8: can't set config #1, error -110

Adding further delays to different locations where usb control
messages are issued just moves the timeouts to other locations,
e.g.:

[   35.400533] usbhid 1-8:1.0: can't add hid device: -110
[   35.401014] usbhid: probe of 1-8:1.0 failed with error -110

The only way to reliably avoid those issues is having a pause after
each usb control message. In approx. 200 boot cycles no more timeouts
were seen.

Addionaly, keep USB_QUIRK_DELAY_INIT as it turned out to be necessary
to have the delay in hub_port_connect() after hub_port_init().

The overall boot time seems not to be influenced by these additional
delays, even on fast machines and lightweight distributions.

Fixes: de3af5bf25 ("usb: quirks: add delay init quirk for Corsair Strafe RGB keyboard")
Cc: stable@vger.kernel.org
Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-03-18 11:18:56 +01:00
..
2016-03-04 23:50:27 -06:00
2012-12-02 00:05:12 +00:00
2016-08-11 09:41:35 -06:00
2018-01-17 09:38:57 +01:00
2015-02-12 18:54:15 -08:00
2018-02-28 10:18:33 +01:00
2017-07-15 12:16:11 +02:00
2018-03-11 16:21:28 +01:00
2017-08-06 18:59:43 -07:00
2014-08-06 18:01:24 -07:00
2015-05-05 13:40:42 -06:00
2018-02-28 10:18:33 +01:00
2014-01-27 21:02:39 -08:00
2012-12-11 17:22:27 -08:00
2013-06-17 16:38:57 -07:00
2017-08-30 10:21:40 +02:00
2016-05-08 23:46:14 -04:00
2016-06-20 12:47:15 -07:00
2010-11-29 08:55:25 +11:00
2016-05-23 17:04:14 -07:00
2017-12-25 14:23:37 +01:00