ZhangXiaoxu
fba217b35e
nfs: Fix nfsi->nrequests count error on nfs_inode_remove_request
[ Upstream commit 33ea5aaa87 ]
When xfstests testing, there are some WARNING as below:
WARNING: CPU: 0 PID: 6235 at fs/nfs/inode.c:122 nfs_clear_inode+0x9c/0xd8
Modules linked in:
CPU: 0 PID: 6235 Comm: umount.nfs
Hardware name: linux,dummy-virt (DT)
pstate: 60000005 (nZCv daif -PAN -UAO)
pc : nfs_clear_inode+0x9c/0xd8
lr : nfs_evict_inode+0x60/0x78
sp : fffffc000f68fc00
x29: fffffc000f68fc00 x28: fffffe00c53155c0
x27: fffffe00c5315000 x26: fffffc0009a63748
x25: fffffc000f68fd18 x24: fffffc000bfaaf40
x23: fffffc000936d3c0 x22: fffffe00c4ff5e20
x21: fffffc000bfaaf40 x20: fffffe00c4ff5d10
x19: fffffc000c056000 x18: 000000000000003c
x17: 0000000000000000 x16: 0000000000000000
x15: 0000000000000040 x14: 0000000000000228
x13: fffffc000c3a2000 x12: 0000000000000045
x11: 0000000000000000 x10: 0000000000000000
x9 : 0000000000000000 x8 : 0000000000000000
x7 : 0000000000000000 x6 : fffffc00084b027c
x5 : fffffc0009a64000 x4 : fffffe00c0e77400
x3 : fffffc000c0563a8 x2 : fffffffffffffffb
x1 : 000000000000764e x0 : 0000000000000001
Call trace:
nfs_clear_inode+0x9c/0xd8
nfs_evict_inode+0x60/0x78
evict+0x108/0x380
dispose_list+0x70/0xa0
evict_inodes+0x194/0x210
generic_shutdown_super+0xb0/0x220
nfs_kill_super+0x40/0x88
deactivate_locked_super+0xb4/0x120
deactivate_super+0x144/0x160
cleanup_mnt+0x98/0x148
__cleanup_mnt+0x38/0x50
task_work_run+0x114/0x160
do_notify_resume+0x2f8/0x308
work_pending+0x8/0x14
The nrequest should be increased/decreased only if PG_INODE_REF flag
was setted.
But in the nfs_inode_remove_request function, it maybe decrease when
no PG_INODE_REF flag, this maybe lead nrequests count error.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ZhangXiaoxu <zhangxiaoxu5@huawei.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-11-06 12:43:07 +01:00
..
2019-10-11 18:18:38 +02:00
2019-08-06 19:05:21 +02:00
2019-03-13 14:03:19 -07:00
2018-12-01 09:42:51 +01:00
2019-10-29 09:17:43 +01:00
2018-12-17 09:28:53 +01:00
2019-10-11 18:18:39 +02:00
2019-10-29 09:17:41 +01:00
2019-08-06 19:05:23 +02:00
2019-06-22 08:16:17 +02:00
2019-07-31 07:28:22 +02:00
2019-05-08 07:20:49 +02:00
2019-03-23 14:35:21 +01:00
2019-02-12 19:45:57 +01:00
2019-07-31 07:28:42 +02:00
2018-11-27 16:10:47 +01:00
2018-12-17 09:28:50 +01:00
2019-03-23 14:35:23 +01:00
2019-10-05 12:48:11 +02:00
2019-11-06 12:42:52 +01:00
2019-10-07 18:55:12 +02:00
2018-12-17 09:28:53 +01:00
2019-10-11 18:18:41 +02:00
2019-10-05 12:48:08 +02:00
2018-12-17 09:28:54 +01:00
2018-12-17 09:28:54 +01:00
2019-05-31 06:47:12 -07:00
2019-07-31 07:28:47 +02:00
2019-05-08 07:20:49 +02:00
2019-05-16 19:42:19 +02:00
2019-06-09 09:18:18 +02:00
2019-11-06 12:43:07 +01:00
2019-07-31 07:28:48 +02:00
2019-02-06 17:31:37 +01:00
2019-10-29 09:17:00 +01:00
2019-10-05 12:48:09 +02:00
2019-10-29 09:17:37 +01:00
2019-06-11 12:21:48 +02:00
2019-07-21 09:04:28 +02:00
2018-11-27 16:10:46 +01:00
2018-12-17 09:28:48 +01:00
2019-09-19 09:08:06 +02:00
2019-07-21 09:04:30 +02:00
2019-05-25 18:25:36 +02:00
2019-10-17 13:44:03 -07:00
2018-12-21 14:13:04 +01:00
2019-10-05 12:48:06 +02:00
2019-07-03 13:15:59 +02:00
2019-11-06 12:42:59 +01:00
2019-04-17 08:37:53 +02:00
2019-04-05 22:31:28 +02:00
2019-05-31 06:47:31 -07:00
2019-08-09 17:53:35 +02:00
2019-02-06 17:31:34 +01:00
2019-04-27 09:35:41 +02:00
2019-03-13 14:03:18 -07:00
2019-02-12 19:46:10 +01:00
2019-08-04 09:32:03 +02:00
2019-04-05 22:31:28 +02:00
2019-07-31 07:28:25 +02:00
2019-06-22 08:16:19 +02:00
2019-04-27 09:35:41 +02:00
2019-10-17 13:43:52 -07:00
2018-12-01 09:42:59 +01:00
2018-11-21 09:24:14 +01:00
2019-07-31 07:28:58 +02:00
2019-05-04 09:15:18 +02:00
2019-09-10 10:32:15 +01:00
2019-05-04 09:15:18 +02:00
2019-10-11 18:18:48 +02:00
2019-08-29 08:26:43 +02:00