Chris Packham f02d577c6f
tipc: Avoid copying bytes beyond the supplied data ...
TLV_SET is called with a data pointer and a len parameter that tells us
how many bytes are pointed to by data. When invoking memcpy() we need
to careful to only copy len bytes.
Previously we would copy TLV_LENGTH(len) bytes which would copy an extra
4 bytes past the end of the data pointer which newer GCC versions
complain about.
In file included from test.c:17:
In function 'TLV_SET',
inlined from 'test' at test.c:186:5:
/usr/include/linux/tipc_config.h:317:3:
warning: 'memcpy' forming offset [33, 36] is out of the bounds [0, 32]
of object 'bearer_name' with type 'char[32]' [-Warray-bounds]
memcpy(TLV_DATA(tlv_ptr), data, tlv_len);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test.c: In function 'test':
test.c::161:10: note:
'bearer_name' declared here
char bearer_name[TIPC_MAX_BEARER_NAME];
^~~~~~~~~~~
We still want to ensure any padding bytes at the end are initialised, do
this with a explicit memset() rather than copy bytes past the end of
data. Apply the same logic to TCM_SET.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz >
Signed-off-by: David S. Miller <davem@davemloft.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-06-11 12:22:34 +02:00
2016-06-17 15:39:46 +02:00
2016-09-09 09:53:35 -03:00
2016-08-22 22:43:35 +02:00
2016-05-29 20:03:21 +01:00
2017-06-17 06:41:58 +02:00
2017-11-02 09:49:13 +01:00
2016-12-05 19:43:02 -05:00
2018-03-28 18:39:19 +02:00
2016-11-13 12:35:13 -05:00
2016-10-04 14:21:41 -07:00
2016-10-11 15:06:31 -07:00
2016-10-11 15:06:31 -07:00
2016-08-09 07:54:43 +02:00
2017-12-05 11:24:34 +01:00
2016-09-02 10:46:44 -07:00
2016-09-23 08:40:28 -04:00
2016-11-13 00:57:53 -05:00
2016-09-29 19:05:06 -05:00
2018-12-08 13:05:11 +01:00
2016-10-03 18:52:14 +02:00
2016-12-07 10:45:57 +01:00
2016-08-02 17:31:41 -04:00
2016-05-03 14:59:30 -07:00
2016-06-23 18:29:56 +08:00
2016-07-02 14:40:40 -04:00
2016-07-20 23:49:49 -04:00
2016-07-20 12:37:39 -07:00
2016-08-05 09:00:54 -04:00
2018-09-19 22:47:12 +02:00
2018-03-22 09:17:38 +01:00
2016-10-03 09:11:14 -07:00
2016-06-08 11:36:02 -07:00
2017-03-15 10:02:44 +08:00
2016-10-01 07:32:32 +02:00
2016-04-26 12:00:49 -04:00
2016-06-15 09:29:17 +02:00
2016-06-07 16:25:49 -07:00
2016-06-17 13:24:05 +02:00
2016-06-18 22:11:39 -07:00
2016-08-18 23:18:42 -07:00
2019-02-20 10:18:35 +01:00
2016-09-24 08:01:26 -04:00
2016-07-25 10:55:39 -07:00
2016-08-22 16:25:14 -07:00
2016-08-22 16:25:15 -07:00
2016-09-25 23:34:19 +02:00
2016-12-06 10:43:32 -05:00
2016-04-26 01:27:07 -04:00
2016-06-27 15:02:51 -04:00
2016-09-21 00:23:01 -04:00
2019-01-13 10:03:48 +01:00
2016-08-17 11:13:08 +02:00
2016-04-25 15:09:11 -04:00
2017-05-03 08:36:36 -07:00
2016-09-30 01:54:28 -04:00
2016-08-22 16:25:15 -07:00
2016-10-23 15:56:23 -07:00
2016-03-22 15:36:02 -07:00
2016-06-27 16:31:25 +01:00
2016-04-12 19:54:58 +01:00
2018-08-15 18:14:52 +02:00
2016-04-25 15:09:10 -04:00
2019-02-20 10:18:35 +01:00
2016-07-11 10:49:52 -03:00
2016-04-23 20:13:24 -04:00
2016-08-23 22:58:51 -07:00
2016-09-09 11:16:36 -03:00
2016-08-23 16:28:04 -03:00
2016-08-12 16:57:20 -07:00
2017-10-21 17:21:37 +02:00
2016-08-15 11:07:21 -07:00
2016-04-23 20:13:24 -04:00
2016-04-04 15:50:30 -04:00
2016-06-16 14:00:50 -07:00
2016-09-26 15:20:37 -04:00
2016-08-02 19:35:21 -04:00
2016-08-02 19:35:21 -04:00
2018-06-06 16:44:33 +02:00
2016-09-22 19:59:41 -05:00
2016-05-17 17:14:21 -06:00
2016-09-08 17:10:27 -07:00
2017-03-22 12:43:34 +01:00
2018-04-08 12:12:43 +02:00
2016-05-30 12:41:44 -03:00
2016-09-21 19:50:02 -04:00
2016-09-23 07:19:06 -04:00
2016-09-27 21:52:00 -04:00
2016-09-27 21:52:00 -04:00
2019-05-14 19:19:39 +02:00
2018-04-20 08:21:04 +02:00
2016-05-08 23:46:14 -04:00
2016-04-26 12:00:48 -04:00
2018-04-24 09:34:16 +02:00
2017-11-21 09:23:28 +01:00
2016-08-02 19:35:31 -04:00
2016-05-05 17:38:53 -07:00
2016-10-19 11:07:57 -04:00
2016-08-08 12:51:58 -07:00
2018-05-22 16:58:01 +02:00
2016-05-20 20:57:27 -07:00
2016-09-27 12:55:50 +02:00
2016-07-12 13:42:10 -03:00
2016-05-04 08:34:14 +02:00
2018-10-18 09:13:25 +02:00
2016-04-04 22:11:20 -04:00
2016-03-30 12:50:17 +02:00
2016-05-05 17:38:53 -07:00
2016-09-20 18:12:38 +05:30
2016-08-02 17:31:41 -04:00
2016-04-23 20:13:24 -04:00
2016-09-21 00:23:00 -04:00
2019-06-11 12:22:34 +02:00
2016-08-26 21:38:41 -07:00
2016-07-26 14:26:42 -07:00
2016-04-30 09:26:55 -07:00
2016-05-10 12:25:04 -04:00
2016-05-20 17:58:30 -07:00
2016-09-19 14:34:41 -03:00
2016-08-02 16:53:54 +03:00
2017-02-23 17:44:37 +01:00
2016-08-01 21:44:52 +03:00
2016-08-02 02:57:29 +03:00
2016-06-10 23:03:55 -07:00
2016-08-09 13:42:38 +03:00
2016-04-30 09:26:55 -07:00
2016-06-25 17:26:35 +03:00
2016-06-09 10:14:39 +02:00
2016-09-09 09:10:07 +02:00
Chris Packham
f02d577c6f