TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
751e8b062af0cec10ebda5c70f02f4a7a67eaade
twx-linux/tools/perf/util
T
History
disconnect3d 71fc11978c perf map: Fix off by one in strncpy() size argument 
commit db2c549407 upstream.

This patch fixes an off-by-one error in strncpy size argument in
tools/perf/util/map.c. The issue is that in:

        strncmp(filename, "/system/lib/", 11)

the passed string literal: "/system/lib/" has 12 bytes (without the NULL
byte) and the passed size argument is 11. As a result, the logic won't
match the ending "/" byte and will pass filepaths that are stored in
other directories e.g. "/system/libmalicious/bin" or just
"/system/libmalicious".

This functionality seems to be present only on Android. I assume the
/system/ directory is only writable by the root user, so I don't think
this bug has much (or any) security impact.

Fixes: eca8183699 ("perf tools: Add automatic remapping of Android libraries")
Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Changbin Du <changbin.du@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: John Keeping <john@metanate.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Lentine <mlentine@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20200309104855.3775-1-dominik.b.czarnota@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-04-02 15:28:24 +02:00
..
c++
…
cs-etm-decoder
…
include
…
intel-pt-decoder
perf intel-pt: Fix sample timestamp wrt non-taken branches
2019-05-25 18:23:33 +02:00
libunwind
…
scripting-engines
perf script python: Add trace_context extension module to sys.modules
2019-04-05 22:33:14 +02:00
annotate.c
perf annotate: Return appropriate error code for allocation failures
2019-11-06 13:05:44 +01:00
annotate.h
…
arm-spe-pkt-decoder.c
…
arm-spe-pkt-decoder.h
…
arm-spe.c
…
arm-spe.h
…
auxtrace.c
…
auxtrace.h
…
block-range.c
…
block-range.h
…
bpf-loader.c
…
bpf-loader.h
…
bpf-prologue.c
…
bpf-prologue.h
…
branch.c
…
branch.h
…
Build
…
build-id.c
perf build-id: Fix memory leak in print_sdt_events()
2019-04-20 09:15:57 +02:00
build-id.h
…
cache.h
…
call-path.c
…
call-path.h
…
callchain.c
…
callchain.h
…
cgroup.c
…
cgroup.h
…
cloexec.c
…
cloexec.h
…
color.c
…
color.h
…
comm.c
…
comm.h
…
compress.h
…
config.c
perf config: Fix a memory leak in collect_config()
2019-04-20 09:15:57 +02:00
config.h
…
counts.c
…
counts.h
…
cpumap.c
perf cpumap: Fix writing to illegal memory in handling cpumap mask
2019-08-29 08:28:47 +02:00
cpumap.h
…
cs-etm.c
…
cs-etm.h
…
ctype.c
…
data-convert-bt.c
perf data: Fix 'strncat may truncate' build failure with recent gcc
2019-06-22 08:15:18 +02:00
data-convert-bt.h
…
data-convert.h
…
data.c
…
data.h
…
db-export.c
…
db-export.h
…
debug.c
…
debug.h
…
demangle-java.c
…
demangle-java.h
…
demangle-rust.c
…
demangle-rust.h
…
drv_configs.c
…
drv_configs.h
…
dso.c
…
dso.h
…
dump-insn.c
…
dump-insn.h
…
dwarf-aux.c
perf probe: Fix to show function entry line as probe-able
2019-12-31 16:36:37 +01:00
dwarf-aux.h
perf probe: Fix to show function entry line as probe-able
2019-12-31 16:36:37 +01:00
dwarf-regs.c
…
env.c
…
env.h
…
event.c
…
event.h
…
evlist.c
…
evlist.h
…
evsel_fprintf.c
…
evsel.c
perf evsel: Make perf_evsel__name() accept a NULL argument
2019-07-26 09:14:08 +02:00
evsel.h
…
expr.h
…
expr.y
…
find-vdso-map.c
…
genelf_debug.c
…
genelf.c
…
genelf.h
…
generate-cmdlist.sh
…
group.h
…
header.c
perf tools: Fix segfault in cpu_cache_level__read()
2019-10-11 18:21:28 +02:00
header.h
…
help-unknown-cmd.c
…
help-unknown-cmd.h
…
hist.c
perf tools: Fix time sorting
2019-11-12 19:20:37 +01:00
hist.h
perf hists: Fix variable name's inconsistency in hists__for_each() macro
2020-01-23 08:21:30 +01:00
intel-bts.c
…
intel-bts.h
…
intel-pt.c
…
intel-pt.h
…
intlist.c
…
intlist.h
…
jit.h
…
jitdump.c
perf inject jit: Fix JIT_CODE_MOVE filename
2019-10-17 13:45:15 -07:00
jitdump.h
…
kvm-stat.h
…
levenshtein.c
…
levenshtein.h
…
llvm-utils.c
perf llvm: Don't access out-of-scope array
2019-10-17 13:45:14 -07:00
llvm-utils.h
…
lzma.c
…
machine.c
perf map: No need to adjust the long name of modules
2020-01-27 14:49:53 +01:00
machine.h
perf record: Fix module size on s390
2019-08-16 10:12:41 +02:00
map.c
perf map: Fix off by one in strncpy() size argument
2020-04-02 15:28:24 +02:00
map.h
…
mem2node.c
…
mem2node.h
…
mem-events.c
…
mem-events.h
…
memswap.c
…
memswap.h
…
metricgroup.c
perf stat: Fix group lookup for metric group
2019-07-26 09:14:15 +02:00
metricgroup.h
…
mmap.c
…
mmap.h
…
namespaces.c
…
namespaces.h
…
ordered-events.c
…
ordered-events.h
…
parse-branch-options.c
…
parse-branch-options.h
…
parse-events.c
perf parse: If pmu configuration fails free terms
2019-12-31 16:35:50 +01:00
parse-events.h
…
parse-events.l
…
parse-events.y
…
parse-regs-options.c
…
parse-regs-options.h
…
path.c
…
path.h
…
perf_regs.c
…
perf_regs.h
perf regs: Make perf_reg_name() return "unknown" instead of NULL
2020-01-04 19:13:14 +01:00
perf-hooks-list.h
…
perf-hooks.c
…
perf-hooks.h
…
PERF-VERSION-GEN
…
pmu.c
perf pmu: Fix uncore PMU alias list for ARM64
2019-07-14 08:11:17 +02:00
pmu.h
…
pmu.l
…
pmu.y
…
print_binary.c
…
print_binary.h
…
probe-event.c
…
probe-event.h
…
probe-file.c
…
probe-file.h
…
probe-finder.c
perf probe: Do not depend on dwfl_module_addrsym()
2020-04-02 15:28:17 +02:00
probe-finder.h
…
pstack.c
…
pstack.h
…
python-ext-sources
…
python.c
…
rb_resort.h
…
rblist.c
…
rblist.h
…
record.c
…
rwsem.c
…
rwsem.h
…
s390-cpumsf-kernel.h
…
s390-cpumsf.c
perf report: Add s390 diagnosic sampling descriptor size
2019-04-05 22:33:07 +02:00
s390-cpumsf.h
…
sane_ctype.h
…
session.c
perf session: Fix potential NULL pointer dereference found by the smatch tool
2019-07-31 07:27:06 +02:00
session.h
…
setns.c
…
setup.py
…
smt.c
…
smt.h
…
sort.c
perf report: Don't shadow inlined symbol with different addr range
2019-04-05 22:33:05 +02:00
sort.h
…
srcline.c
perf report: Don't shadow inlined symbol with different addr range
2019-04-05 22:33:05 +02:00
srcline.h
…
stat-shadow.c
perf stat: Fix shadow stats for clock events
2020-03-05 16:42:22 +01:00
stat.c
perf stat: Reset previous counts on repeat with interval
2019-10-11 18:21:29 +02:00
stat.h
perf stat: Reset previous counts on repeat with interval
2019-10-11 18:21:29 +02:00
strbuf.c
perf strbuf: Remove redundant va_end() in strbuf_addv()
2020-01-04 19:13:24 +01:00
strbuf.h
…
strfilter.c
…
strfilter.h
…
string2.h
…
string.c
…
strlist.c
…
strlist.h
…
svghelper.c
…
svghelper.h
…
symbol_fprintf.c
…
symbol-elf.c
…
symbol-minimal.c
…
symbol.c
perf annotate: Fix s390 gap between kernel end and module start
2019-08-16 10:12:41 +02:00
symbol.h
perf annotate: Fix s390 gap between kernel end and module start
2019-08-16 10:12:41 +02:00
syscalltbl.c
…
syscalltbl.h
…
target.c
…
target.h
…
term.c
…
term.h
…
thread_map.c
…
thread_map.h
…
thread-stack.c
…
thread-stack.h
…
thread.c
perf db-export: Fix thread__exec_comm()
2019-08-16 10:12:41 +02:00
thread.h
…
time-utils.c
…
time-utils.h
…
tool.h
…
top.c
…
top.h
…
trace-event-info.c
…
trace-event-parse.c
…
trace-event-read.c
…
trace-event-scripting.c
…
trace-event.c
…
trace-event.h
…
trigger.h
…
tsc.c
…
tsc.h
…
units.c
…
units.h
…
unwind-libdw.c
…
unwind-libdw.h
…
unwind-libunwind-local.c
…
unwind-libunwind.c
…
unwind.h
…
usage.c
…
util-cxx.h
…
util.c
…
util.h
…
values.c
…
values.h
…
vdso.c
…
vdso.h
…
xyarray.c
…
xyarray.h
libperf: Fix alignment trap with xyarray contents in 'perf stat'
2019-10-05 13:09:47 +02:00
zlib.c
…