Saravana Kannan 7008e58c63 driver core: Fix lockdep warning on wfs_lock ... There's a potential deadlock with the following cycle: wfs_lock --> device_links_lock --> kn->count Fix this by simply dropping the lock around a list_empty() check that's just exported to a sysfs file. The sysfs file output is an instantaneous check anyway and the lock doesn't really add any protection. Lockdep log: [ 48.808132] [ 48.808132] the existing dependency chain (in reverse order) is: [ 48.809069] [ 48.809069] -> #2 (kn->count){++++}: [ 48.809707] __kernfs_remove.llvm.7860393000964815146+0x2d4/0x460 [ 48.810537] kernfs_remove_by_name_ns+0x54/0x9c [ 48.811171] sysfs_remove_file_ns+0x18/0x24 [ 48.811762] device_del+0x2b8/0x5a8 [ 48.812269] __device_link_del+0x98/0xb8 [ 48.812829] device_links_driver_bound+0x210/0x2d8 [ 48.813496] driver_bound+0x44/0xf8 [ 48.814000] really_probe+0x340/0x6e0 [ 48.814526] driver_probe_device+0xb8/0x100 [ 48.815117] device_driver_attach+0x78/0xb8 [ 48.815708] __driver_attach+0xe0/0x194 [ 48.816255] bus_for_each_dev+0xa8/0x11c [ 48.816816] driver_attach+0x24/0x30 [ 48.817331] bus_add_driver+0x100/0x1e0 [ 48.817880] driver_register+0x78/0x114 [ 48.818427] __platform_driver_register+0x44/0x50 [ 48.819089] 0xffffffdbb3227038 [ 48.819551] do_one_initcall+0xd8/0x1e0 [ 48.820099] do_init_module+0xd8/0x298 [ 48.820636] load_module+0x3afc/0x44c8 [ 48.821173] __arm64_sys_finit_module+0xbc/0xf0 [ 48.821807] el0_svc_common+0xbc/0x1d0 [ 48.822344] el0_svc_handler+0x74/0x98 [ 48.822882] el0_svc+0x8/0xc [ 48.823310] [ 48.823310] -> #1 (device_links_lock){+.+.}: [ 48.824036] __mutex_lock_common+0xe0/0xe44 [ 48.824626] mutex_lock_nested+0x28/0x34 [ 48.825185] device_link_add+0xd4/0x4ec [ 48.825734] of_link_to_suppliers+0x158/0x204 [ 48.826347] of_fwnode_add_links+0x50/0x64 [ 48.826928] device_link_add_missing_supplier_links+0x90/0x11c [ 48.827725] fw_devlink_resume+0x58/0x130 [ 48.828296] of_platform_default_populate_init+0xb4/0xd0 [ 48.829030] do_one_initcall+0xd8/0x1e0 [ 48.829578] do_initcall_level+0xb8/0xcc [ 48.830137] do_basic_setup+0x60/0x7c [ 48.830662] kernel_init_freeable+0x128/0x1ac [ 48.831275] kernel_init+0x18/0x29c [ 48.831781] ret_from_fork+0x10/0x18 [ 48.832297] [ 48.832297] -> #0 (wfs_lock){+.+.}: [ 48.832922] __lock_acquire+0xe04/0x2e20 [ 48.833480] lock_acquire+0xbc/0xec [ 48.833984] __mutex_lock_common+0xe0/0xe44 [ 48.834577] mutex_lock_nested+0x28/0x34 [ 48.835136] waiting_for_supplier_show+0x3c/0x98 [ 48.835781] dev_attr_show+0x48/0xb4 [ 48.836295] sysfs_kf_seq_show+0xe8/0x184 [ 48.836864] kernfs_seq_show+0x48/0x8c [ 48.837401] seq_read+0x1c8/0x600 [ 48.837884] kernfs_fop_read+0x68/0x204 [ 48.838431] __vfs_read+0x60/0x214 [ 48.838925] vfs_read+0xbc/0x15c [ 48.839397] ksys_read+0x78/0xe4 [ 48.839869] __arm64_sys_read+0x1c/0x28 [ 48.840416] el0_svc_common+0xbc/0x1d0 [ 48.840953] el0_svc_handler+0x74/0x98 [ 48.841490] el0_svc+0x8/0xc [ 48.841917] [ 48.841917] other info that might help us debug this: [ 48.841917] [ 48.842920] Chain exists of: [ 48.842920] wfs_lock --> device_links_lock --> kn->count [ 48.842920] [ 48.844152] Possible unsafe locking scenario: [ 48.844152] [ 48.844895] CPU0 CPU1 [ 48.845463] ---- ---- [ 48.846032] lock(kn->count); [ 48.846417] lock(device_links_lock); [ 48.847203] lock(kn->count); [ 48.847902] lock(wfs_lock); [ 48.848276] [ 48.848276] *** DEADLOCK *** Reported-by: Cheng-Jui.Wang@mediatek.com Signed-off-by: Saravana Kannan <saravanak@google.com> Link: https://lore.kernel.org/r/20201104205431.3795207-1-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-11-09 18:17:52 +01:00
..
firmware_loader	Char/Misc driver patches for 5.10-rc1	2020-10-15 10:01:51 -07:00
power	PM: runtime: Drop pm_runtime_clean_up_links()	2020-11-02 18:14:07 +01:00
regmap	Merge remote-tracking branch 'regmap/for-5.10' into regmap-next	2020-10-05 18:53:24 +01:00
test	drivers: base: default KUNIT_* fragments to KUNIT_ALL_TESTS	2020-06-01 14:24:25 -06:00
arch_topology.c	Driver Core patches for 5.10-rc1	2020-10-14 16:09:32 -07:00
attribute_container.c	scsi: drivers: base: Support atomic version of attribute_container_device_trigger	2020-01-15 22:55:36 -05:00
base.h	driver core: add deferring probe reason to devices_deferred property	2020-07-30 09:03:43 +02:00
bus.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
cacheinfo.c	drivers core: Use sysfs_emit for shared_cpu_map_show and shared_cpu_list_show	2020-10-02 13:24:40 +02:00
class.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
component.c	component: Silence bind error on -EPROBE_DEFER	2020-04-28 17:54:15 +02:00
container.c
core.c	driver core: Fix lockdep warning on wfs_lock	2020-11-09 18:17:52 +01:00
cpu.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
dd.c	PM: runtime: Resume the device earlier in __device_release_driver()	2020-11-02 18:14:07 +01:00
devcoredump.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
devres.c	devres: provide devm_krealloc()	2020-09-08 13:32:06 +02:00
devtmpfs.c	init: add an init_chroot helper	2020-07-31 08:17:52 +02:00
driver.c	drivers: base: Convert to printk alias functions	2020-07-10 14:16:44 +02:00
firmware.c
hypervisor.c
init.c
isa.c
Kconfig	drivers: base: default KUNIT_* fragments to KUNIT_ALL_TESTS	2020-06-01 14:24:25 -06:00
Makefile	device property: Move fwnode_connection_find_match() under drivers/base/property.c	2020-09-08 13:32:06 +02:00
map.c
memory.c	mm/memory_hotplug: prepare passing flags to add_memory() and friends	2020-10-16 11:11:18 -07:00
module.c
node.c	mm: don't panic when links can't be created in sysfs	2020-10-16 11:11:18 -07:00
pinctrl.c
platform-msi.c	platform-msi: Fix typos in comment	2020-05-18 10:28:30 +01:00
platform.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
property.c	device property: Move fwnode_connection_find_match() under drivers/base/property.c	2020-09-08 13:32:06 +02:00
soc.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
swnode.c	software node: Use software_node_unregister() when unregistering group of nodes	2020-07-10 14:35:37 +02:00
syscore.c	syscore: Use pm_pr_dbg() for syscore_{suspend,resume}()	2020-09-08 13:32:06 +02:00
topology.c	drivers core: Miscellaneous changes for sysfs_emit	2020-10-02 13:12:07 +02:00
transport_class.c	scsi: drivers: base: Propagate errors through the transport component	2020-01-15 22:55:37 -05:00