TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
677e362ba807f3aafe6f405c07e0b37244da5222
twx-linux/kernel
T
History
Zhihao Cheng 677e362ba8 blktrace: Fix uaf in blk_trace access after removing by sysfs 
[ Upstream commit 5afedf670c ]

There is an use-after-free problem triggered by following process:

      P1(sda)				P2(sdb)
			echo 0 > /sys/block/sdb/trace/enable
			  blk_trace_remove_queue
			    synchronize_rcu
			    blk_trace_free
			      relay_close
rcu_read_lock
__blk_add_trace
  trace_note_tsk
  (Iterate running_trace_list)
			        relay_close_buf
				  relay_destroy_buf
				    kfree(buf)
    trace_note(sdb's bt)
      relay_reserve
        buf->offset <- nullptr deference (use-after-free) !!!
rcu_read_unlock

[  502.714379] BUG: kernel NULL pointer dereference, address:
0000000000000010
[  502.715260] #PF: supervisor read access in kernel mode
[  502.715903] #PF: error_code(0x0000) - not-present page
[  502.716546] PGD 103984067 P4D 103984067 PUD 17592b067 PMD 0
[  502.717252] Oops: 0000 [#1] SMP
[  502.720308] RIP: 0010:trace_note.isra.0+0x86/0x360
[  502.732872] Call Trace:
[  502.733193]  __blk_add_trace.cold+0x137/0x1a3
[  502.733734]  blk_add_trace_rq+0x7b/0xd0
[  502.734207]  blk_add_trace_rq_issue+0x54/0xa0
[  502.734755]  blk_mq_start_request+0xde/0x1b0
[  502.735287]  scsi_queue_rq+0x528/0x1140
...
[  502.742704]  sg_new_write.isra.0+0x16e/0x3e0
[  502.747501]  sg_ioctl+0x466/0x1100

Reproduce method:
  ioctl(/dev/sda, BLKTRACESETUP, blk_user_trace_setup[buf_size=127])
  ioctl(/dev/sda, BLKTRACESTART)
  ioctl(/dev/sdb, BLKTRACESETUP, blk_user_trace_setup[buf_size=127])
  ioctl(/dev/sdb, BLKTRACESTART)

  echo 0 > /sys/block/sdb/trace/enable &
  // Add delay(mdelay/msleep) before kernel enters blk_trace_free()

  ioctl$SG_IO(/dev/sda, SG_IO, ...)
  // Enters trace_note_tsk() after blk_trace_free() returned
  // Use mdelay in rcu region rather than msleep(which may schedule out)

Remove blk_trace from running_list before calling blk_trace_free() by
sysfs if blk_trace is at Blktrace_running state.

Fixes: c71a896154 ("blktrace: add ftrace plugin")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Link: https://lore.kernel.org/r/20210923134921.109194-1-chengzhihao1@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-10-06 15:31:15 +02:00
..
bpf
bpf: Fix pointer arithmetic mask tightening under state pruning
2021-09-22 11:47:59 +02:00
cgroup
cgroup1: don't allow '\n' in renaming
2021-06-16 11:54:59 +02:00
configs
…
debug
kdb: Make memory allocations more robust
2021-03-04 09:39:31 +01:00
dma
swiotlb: fix "x86: Don't panic if can not alloc buffer for swiotlb"
2020-11-18 19:18:51 +01:00
events
events: Reuse value read using READ_ONCE instead of re-reading it
2021-09-22 11:48:11 +02:00
gcov
gcov: add support for GCC 10.1
2020-09-17 13:45:31 +02:00
irq
genirq/msi: Ensure deactivation on teardown
2021-08-26 08:36:40 -04:00
livepatch
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-10-07 18:57:10 +02:00
locking
locking/mutex: Fix HANDOFF condition
2021-09-22 11:47:48 +02:00
power
PM: hibernate: flush swap writer after marking
2021-02-03 23:23:24 +01:00
printk
printk: fix deadlock when kernel panic
2021-03-04 09:39:57 +01:00
rcu
rcu: Fix missed wakeup of exp_wq waiters
2021-09-26 13:39:46 +02:00
sched
sched/deadline: Fix missing clock update in migrate_task_rq_dl()
2021-09-22 11:47:49 +02:00
time
hrtimer: Avoid double reprogramming in __hrtimer_start_range_ns()
2021-09-22 11:47:49 +02:00
trace
blktrace: Fix uaf in blk_trace access after removing by sysfs
2021-10-06 15:31:15 +02:00
.gitignore
…
acct.c
…
async.c
…
audit_fsnotify.c
…
audit_tree.c
audit: Embed key into chunk
2019-12-13 08:51:11 +01:00
audit_watch.c
audit: CONFIG_CHANGE don't log internal bookkeeping as an event
2020-10-01 13:14:33 +02:00
audit.c
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:05:13 +02:00
audit.h
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:05:13 +02:00
auditfilter.c
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:05:13 +02:00
auditsc.c
audit: print empty EXECVE args
2019-12-01 09:17:17 +01:00
backtracetest.c
…
bounds.c
…
capability.c
LSM: generalize flag passing to security_capable
2020-01-23 08:21:29 +01:00
compat.c
make 'user_access_begin()' do 'access_ok()'
2020-06-22 09:04:58 +02:00
configs.c
…
context_tracking.c
…
cpu_pm.c
kernel/cpu_pm: Fix uninitted local in cpu_pm
2020-06-22 09:05:28 +02:00
cpu.c
cpu/hotplug: Cure the cpusets trainwreck
2021-07-20 16:16:04 +02:00
crash_core.c
…
crash_dump.c
…
cred.c
memcg: account security cred as well to kmemcg
2020-01-09 10:19:00 +01:00
delayacct.c
…
dma.c
…
exec_domain.c
…
exit.c
futex: Mark the begin of futex exit explicitly
2021-01-30 13:32:11 +01:00
extable.c
…
fail_function.c
fail_function: Remove a redundant mutex unlock
2020-11-24 13:27:23 +01:00
fork.c
mm/hugetlb: initialize hugetlb_usage in mm_init
2021-09-22 11:48:09 +02:00
freezer.c
…
futex.c
mm, futex: fix shared futex pgoff on shmem huge page
2021-07-11 12:49:30 +02:00
groups.c
…
hung_task.c
…
iomem.c
…
irq_work.c
…
jump_label.c
locking/static_key: Fix false positive warnings on concurrent dec/inc
2021-03-04 09:39:30 +01:00
kallsyms.c
kallsyms: Refactor kallsyms_show_value() to take cred
2020-07-16 08:17:26 +02:00
kcmp.c
…
Kconfig.freezer
…
Kconfig.hz
…
Kconfig.locks
…
Kconfig.preempt
…
kcov.c
…
kexec_core.c
kernel: kexec: remove the lock operation of system_transition_mutex
2021-02-03 23:23:23 +01:00
kexec_file.c
kernel: kexec_file: fix error return code of kexec_calculate_store_digests()
2021-05-22 10:59:44 +02:00
kexec_internal.h
…
kexec.c
…
kmod.c
kmod: make request_module() return an error when autoloading is disabled
2020-04-17 10:48:52 +02:00
kprobes.c
tracing/kprobe: Fix to support kretprobe events on unloaded modules
2021-02-13 13:51:13 +01:00
ksysfs.c
…
kthread.c
kthread: prevent deadlock when kthread_mod_delayed_work() races with kthread_cancel_delayed_work_sync()
2021-07-11 12:49:31 +02:00
latencytop.c
…
Makefile
elfcore: fix building with clang
2021-02-10 09:21:06 +01:00
memremap.c
mm/memory_hotplug: shrink zones when offlining memory
2020-01-29 16:43:27 +01:00
module_signing.c
…
module-internal.h
…
module.c
module: limit enabling module.sig_enforce
2021-06-30 08:48:28 -04:00
notifier.c
x86/mm: split vmalloc_sync_all()
2020-03-25 08:06:13 +01:00
nsproxy.c
…
padata.c
padata: add separate cpuhp node for CPUHP_PADATA_DEAD
2021-08-08 08:54:30 +02:00
panic.c
kernel/panic.c: do not append newline to the stack protector panic string
2019-12-01 09:17:10 +01:00
params.c
…
pid_namespace.c
memcg: enable accounting for pids in nested pid namespaces
2021-09-22 11:48:09 +02:00
pid.c
…
profile.c
profiling: fix shift-out-of-bounds bugs
2021-09-26 13:39:48 +02:00
ptrace.c
ptrace: make ptrace() fail if the tracee changed its pid unexpectedly
2021-05-26 11:48:32 +02:00
range.c
…
reboot.c
reboot: fix overflow parsing reboot cpu number
2020-11-18 19:18:52 +01:00
relay.c
kernel/relay.c: fix memleak on destroy relay channel
2020-08-26 10:30:59 +02:00
resource.c
resource: fix locking in find_next_iomem_res()
2019-09-16 08:22:20 +02:00
rseq.c
…
seccomp.c
seccomp: Add missing return in non-void function
2021-03-04 09:39:54 +01:00
signal.c
ptrace: fix task_join_group_stop() for the case when current is traced
2020-11-10 12:35:53 +01:00
smp.c
smp: Fix smp_call_function_single_async prototype
2021-05-22 10:59:39 +02:00
smpboot.c
kthread: Extract KTHREAD_IS_PER_CPU
2021-02-07 14:48:38 +01:00
smpboot.h
…
softirq.c
…
stacktrace.c
…
stop_machine.c
…
sys_ni.c
…
sys.c
prctl: allow to setup brk for et_dyn executables
2021-09-26 13:39:47 +02:00
sysctl_binary.c
…
sysctl.c
sysctl: handle overflow in proc_get_long
2021-02-07 14:48:37 +01:00
task_work.c
…
taskstats.c
taskstats: fix data-race
2020-01-09 10:18:59 +01:00
test_kprobes.c
…
torture.c
…
tracepoint.c
tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing
2021-07-20 16:15:42 +02:00
tsacct.c
…
ucount.c
…
uid16.c
…
uid16.h
…
umh.c
usermodehelper: reset umask to default before executing user process
2020-10-14 10:31:21 +02:00
up.c
smp: Fix smp_call_function_single_async prototype
2021-05-22 10:59:39 +02:00
user_namespace.c
…
user-return-notifier.c
…
user.c
…
utsname_sysctl.c
…
utsname.c
…
watchdog_hld.c
…
watchdog.c
watchdog/softlockup: Enforce that timestamp is valid on boot
2020-02-24 08:34:49 +01:00
workqueue_internal.h
…
workqueue.c
workqueue: fix UAF in pwq_unbound_release_workfn()
2021-07-31 08:22:37 +02:00