TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
3be9334fbfda238caf1d3692fbdb8a7b731441b6
twx-linux/drivers
T
History
Pavel Skripkin 2397b9e118 phy: mdio: fix memory leak 
[ Upstream commit ca6e11c337 ]

Syzbot reported memory leak in MDIO bus interface, the problem was in
wrong state logic.

MDIOBUS_ALLOCATED indicates 2 states:
	1. Bus is only allocated
	2. Bus allocated and __mdiobus_register() fails, but
	   device_register() was called

In case of device_register() has been called we should call put_device()
to correctly free the memory allocated for this device, but mdiobus_free()
calls just kfree(dev) in case of MDIOBUS_ALLOCATED state

To avoid this behaviour we need to set bus->state to MDIOBUS_UNREGISTERED
_before_ calling device_register(), because put_device() should be
called even in case of device_register() failure.

Link: https://lore.kernel.org/netdev/YVMRWNDZDUOvQjHL@shell.armlinux.org.uk/
Fixes: 46abc02175 ("phylib: give mdio buses a device tree presence")
Reported-and-tested-by: syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/eceae1429fbf8fa5c73dd2a0d39d525aa905074d.1633024062.git.paskripkin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-10-13 10:10:51 +02:00
..
accessibility
…
acpi
ACPI: NFIT: Fix support for virtual SPA ranges
2021-08-26 08:36:36 -04:00
amba
…
android
…
ata
libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD.
2021-10-09 14:11:03 +02:00
atm
atm: nicstar: register the interrupt handler in the right place
2021-07-20 16:16:01 +02:00
auxdisplay
…
base
PM: base: power: don't try to use non-existing RTC for storing data
2021-09-22 11:48:10 +02:00
bcma
bcma: Fix memory leak for internally-handled cores
2021-09-22 11:47:55 +02:00
block
cryptoloop: add a deprecation warning
2021-09-22 11:47:46 +02:00
bluetooth
Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca btsoc.
2021-07-20 16:16:03 +02:00
bus
…
cdrom
cdrom: gdrom: initialize global variable at init time
2021-05-26 11:48:34 +02:00
char
virtio_console: Assure used length from device is limited
2021-07-20 16:16:12 +02:00
clk
clk: kirkwood: Fix a clocking boot regression
2021-09-22 11:47:57 +02:00
clocksource
clocksource/drivers/sh_cmt: Fix wrong setting if don't request IRQ for clock source channel
2021-09-22 11:47:51 +02:00
connector
…
cpufreq
cpufreq: schedutil: Destroy mutex before kobject_put() frees the memory
2021-10-06 15:31:21 +02:00
cpuidle
…
crypto
crypto: ccp - fix resource leaks in ccp_run_aes_gcm_cmd()
2021-10-06 15:31:27 +02:00
dax
…
dca
…
devfreq
…
dio
…
dma
dmaengine: xilinx_dma: Set DMA mask for coherent APIs
2021-09-26 13:39:48 +02:00
dma-buf
dma-buf/sync_file: Don't leak fences on merge failure
2021-07-28 11:13:45 +02:00
edac
EDAC/synopsys: Fix wrong value type assignment for edac_mode
2021-10-06 15:31:26 +02:00
eisa
…
extcon
extcon: max8997: Add missing modalias string
2021-07-20 16:15:57 +02:00
firewire
…
firmware
firmware: arm_scmi: Ensure drivers provide a probe function
2021-08-08 08:54:29 +02:00
fmc
…
fpga
fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
2021-10-06 15:31:14 +02:00
fsi
fsi/sbefifo: Fix reset timeout
2021-07-20 16:15:55 +02:00
gnss
…
gpio
gpio: uniphier: Fix void functions to remove return value
2021-10-06 15:31:13 +02:00
gpu
drm/amd/display: Pass PCI deviceid into DC
2021-10-06 15:31:21 +02:00
hid
HID: usbhid: free raw_report buffers in usbhid_stop
2021-10-06 15:31:28 +02:00
hsi
HSI: core: fix resource leaks in hsi_add_client_from_dt()
2021-05-22 10:59:34 +02:00
hv
hv_utils: Fix passing zero to 'PTR_ERR' warning
2021-07-20 16:15:45 +02:00
hwmon
hwmon: (tmp421) fix rounding for negative values
2021-10-06 15:31:23 +02:00
hwspinlock
…
hwtracing
intel_th: Wait until port is in reset before programming it
2021-07-20 16:16:10 +02:00
i2c
i2c: mt65xx: fix IRQ check
2021-09-22 11:47:54 +02:00
ide
…
idle
…
iio
iio: dac: ad5624r: Fix incorrect handling of an optional regulator.
2021-09-22 11:48:02 +02:00
infiniband
RDMA/iwcm: Release resources if iw_cm module initialization fails
2021-09-22 11:48:01 +02:00
input
Input: hideep - fix the uninitialized use in hideep_nvm_unlock()
2021-07-20 16:16:09 +02:00
iommu
iommu/vt-d: Fix agaw for a supported 48 bit guest address width
2021-08-26 08:36:42 -04:00
ipack
ipack: ipoctal: fix module reference leak
2021-10-06 15:31:25 +02:00
irqchip
irqchip/gic-v3-its: Fix potential VPE leak on error
2021-10-06 15:31:15 +02:00
isdn
mISDN: fix possible use-after-free in HFC_cleanup()
2021-07-20 16:15:59 +02:00
leds
leds: ktd2692: Fix an error handling path
2021-07-20 16:15:57 +02:00
lightnvm
…
macintosh
…
mailbox
…
mcb
mcb: fix error handling in mcb_alloc_bus()
2021-10-06 15:31:12 +02:00
md
md: fix a lock order reversal in md_alloc
2021-10-06 15:31:15 +02:00
media
media: tegra-cec: Handle errors of clk_prepare_enable()
2021-09-22 11:48:06 +02:00
memory
memory: fsl_ifc: fix leak of private memory on probe failure
2021-07-20 16:16:15 +02:00
memstick
…
message
…
mfd
mfd: axp20x: Update AXP288 volatile ranges
2021-09-22 11:48:13 +02:00
misc
VMCI: fix NULL pointer dereference when unmapping queue pair
2021-09-22 11:48:00 +02:00
mmc
mmc: core: Return correct emmc response in case of ioctl error
2021-09-22 11:48:08 +02:00
mtd
mtd: rawnand: cafe: Fix a resource leak in the error handling path of 'cafe_nand_probe()'
2021-09-22 11:48:13 +02:00
mux
…
net
phy: mdio: fix memory leak
2021-10-13 10:10:51 +02:00
nfc
nfc: nfcsim: fix use after free during module unload
2021-08-04 12:23:45 +02:00
ntb
NTB: perf: Fix an error code in perf_setup_inbuf()
2021-09-22 11:48:13 +02:00
nubus
…
nvdimm
…
nvme
nvme-multipath: fix ANA state updates when a namespace is not present
2021-10-06 15:31:16 +02:00
nvmem
…
of
of: Don't allow __of_attached_node_sysfs() without CONFIG_SYSFS
2021-09-22 11:48:07 +02:00
opp
opp: remove WARN when no valid OPPs remain
2021-09-03 09:58:01 +02:00
oprofile
…
parisc
parisc: Move pci_dev_is_behind_card_dino to where it is used
2021-09-26 13:39:48 +02:00
parport
parport: remove non-zero check on count
2021-09-22 11:48:08 +02:00
pci
PCI: aardvark: Fix checking for PIO status
2021-10-06 15:31:19 +02:00
pcmcia
pcmcia: i82092: fix a null pointer dereference bug
2021-08-12 13:19:43 +02:00
perf
…
phy
phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe()
2021-07-20 16:15:57 +02:00
pinctrl
pinctrl: single: Fix error return code in pcs_parse_bits_in_pinctrl_entry()
2021-09-22 11:48:01 +02:00
platform
platform/chrome: cros_ec_proto: Send command again when timeout occurs
2021-09-22 11:48:10 +02:00
pnp
…
power
power: supply: max17042: handle fails of reading status register
2021-09-22 11:47:59 +02:00
powercap
…
pps
…
ps3
…
ptp
ptp_pch: Restore dependency on PCI
2021-08-26 08:36:46 -04:00
pwm
pwm: stm32-lp: Don't modify HW state in .remove() callback
2021-09-26 13:39:49 +02:00
rapidio
rapidio: handle create_workqueue() failure
2021-05-26 11:48:33 +02:00
ras
…
regulator
regulator: da9052: Ensure enough delay time for .set_voltage_time_sel
2021-07-20 16:15:45 +02:00
remoteproc
…
reset
reset: ti-syscon: fix to_ti_syscon_reset_data macro
2021-07-28 11:13:42 +02:00
rpmsg
rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()
2021-05-22 10:59:42 +02:00
rtc
rtc: tps65910: Correct driver module alias
2021-09-22 11:47:57 +02:00
s390
s390/cio: add dev_busid sysfs entry for each subchannel
2021-09-22 11:47:50 +02:00
sbus
…
scsi
scsi: ses: Retry failed Send/Receive Diagnostic commands
2021-10-09 14:11:03 +02:00
sfi
…
sh
…
siox
…
slimbus
slimbus: ngd: reset dma setup during runtime pm
2021-08-26 08:36:48 -04:00
sn
…
soc
soc: qcom: smsm: Fix missed interrupts if state changes while masked
2021-09-22 11:47:52 +02:00
soundwire
…
spi
spi: Fix tegra20 build with CONFIG_PM=n
2021-10-06 15:31:18 +02:00
spmi
…
ssb
ssb: Fix error return code in ssb_bus_scan()
2021-07-20 16:15:50 +02:00
staging
erofs: fix up erofs_lookup tracepoint
2021-10-06 15:31:18 +02:00
target
scsi: target: Fix protect handling in WRITE SAME(32)
2021-07-28 11:13:48 +02:00
tc
…
tee
optee: Clear stale cache entries during initialization
2021-08-12 13:19:42 +02:00
thermal
thermal/core: Potential buffer overflow in thermal_build_list_of_policies()
2021-10-06 15:31:15 +02:00
thunderbolt
thunderbolt: dma_port: Fix NVM read buffer bounds and offset issue
2021-06-03 08:38:04 +02:00
tty
tty: Fix out-of-bound vmalloc access in imageblit
2021-10-06 15:31:20 +02:00
uio
…
usb
USB: cdc-acm: fix break reporting
2021-10-13 10:10:50 +02:00
uwb
…
vfio
vfio: Use config not menuconfig for VFIO_NOIOMMU
2021-09-22 11:48:01 +02:00
vhost
vringh: Use wiov->used to check for read/write desc order
2021-09-03 09:58:02 +02:00
video
video: fbdev: riva: Error out if 'pixclock' equals zero
2021-09-22 11:48:04 +02:00
virt
…
virtio
virtio_pci: Support surprise removal of virtio pci device
2021-09-03 09:58:02 +02:00
visorbus
visorbus: fix error return code in visorchipset_init()
2021-07-20 16:15:55 +02:00
vlynq
…
vme
…
w1
w1: ds2438: fixing bug that would always get page0
2021-07-20 16:16:07 +02:00
watchdog
Revert "watchdog: iTCO_wdt: Account for rebooting on second timeout"
2021-08-08 08:54:29 +02:00
xen
xen/balloon: fix cancelled balloon action
2021-10-13 10:10:50 +02:00
zorro
…
Kconfig
…
Makefile
…