Files
twx-linux/include/linux
Toshiaki Makita 3f74460e5b vlan: Fix reading memory beyond skb->tail in skb_vlan_tagged_multi
[ Upstream commit 7ce2367254 ]

Syzkaller spotted an old bug which leads to reading skb beyond tail by 4
bytes on vlan tagged packets.
This is caused because skb_vlan_tagged_multi() did not check
skb_headlen.

BUG: KMSAN: uninit-value in eth_type_vlan include/linux/if_vlan.h:283 [inline]
BUG: KMSAN: uninit-value in skb_vlan_tagged_multi include/linux/if_vlan.h:656 [inline]
BUG: KMSAN: uninit-value in vlan_features_check include/linux/if_vlan.h:672 [inline]
BUG: KMSAN: uninit-value in dflt_features_check net/core/dev.c:2949 [inline]
BUG: KMSAN: uninit-value in netif_skb_features+0xd1b/0xdc0 net/core/dev.c:3009
CPU: 1 PID: 3582 Comm: syzkaller435149 Not tainted 4.16.0+ #82
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
  __dump_stack lib/dump_stack.c:17 [inline]
  dump_stack+0x185/0x1d0 lib/dump_stack.c:53
  kmsan_report+0x142/0x240 mm/kmsan/kmsan.c:1067
  __msan_warning_32+0x6c/0xb0 mm/kmsan/kmsan_instr.c:676
  eth_type_vlan include/linux/if_vlan.h:283 [inline]
  skb_vlan_tagged_multi include/linux/if_vlan.h:656 [inline]
  vlan_features_check include/linux/if_vlan.h:672 [inline]
  dflt_features_check net/core/dev.c:2949 [inline]
  netif_skb_features+0xd1b/0xdc0 net/core/dev.c:3009
  validate_xmit_skb+0x89/0x1320 net/core/dev.c:3084
  __dev_queue_xmit+0x1cb2/0x2b60 net/core/dev.c:3549
  dev_queue_xmit+0x4b/0x60 net/core/dev.c:3590
  packet_snd net/packet/af_packet.c:2944 [inline]
  packet_sendmsg+0x7c57/0x8a10 net/packet/af_packet.c:2969
  sock_sendmsg_nosec net/socket.c:630 [inline]
  sock_sendmsg net/socket.c:640 [inline]
  sock_write_iter+0x3b9/0x470 net/socket.c:909
  do_iter_readv_writev+0x7bb/0x970 include/linux/fs.h:1776
  do_iter_write+0x30d/0xd40 fs/read_write.c:932
  vfs_writev fs/read_write.c:977 [inline]
  do_writev+0x3c9/0x830 fs/read_write.c:1012
  SYSC_writev+0x9b/0xb0 fs/read_write.c:1085
  SyS_writev+0x56/0x80 fs/read_write.c:1082
  do_syscall_64+0x309/0x430 arch/x86/entry/common.c:287
  entry_SYSCALL_64_after_hwframe+0x3d/0xa2
RIP: 0033:0x43ffa9
RSP: 002b:00007fff2cff3948 EFLAGS: 00000217 ORIG_RAX: 0000000000000014
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 000000000043ffa9
RDX: 0000000000000001 RSI: 0000000020000080 RDI: 0000000000000003
RBP: 00000000006cb018 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000217 R12: 00000000004018d0
R13: 0000000000401960 R14: 0000000000000000 R15: 0000000000000000

Uninit was created at:
  kmsan_save_stack_with_flags mm/kmsan/kmsan.c:278 [inline]
  kmsan_internal_poison_shadow+0xb8/0x1b0 mm/kmsan/kmsan.c:188
  kmsan_kmalloc+0x94/0x100 mm/kmsan/kmsan.c:314
  kmsan_slab_alloc+0x11/0x20 mm/kmsan/kmsan.c:321
  slab_post_alloc_hook mm/slab.h:445 [inline]
  slab_alloc_node mm/slub.c:2737 [inline]
  __kmalloc_node_track_caller+0xaed/0x11c0 mm/slub.c:4369
  __kmalloc_reserve net/core/skbuff.c:138 [inline]
  __alloc_skb+0x2cf/0x9f0 net/core/skbuff.c:206
  alloc_skb include/linux/skbuff.h:984 [inline]
  alloc_skb_with_frags+0x1d4/0xb20 net/core/skbuff.c:5234
  sock_alloc_send_pskb+0xb56/0x1190 net/core/sock.c:2085
  packet_alloc_skb net/packet/af_packet.c:2803 [inline]
  packet_snd net/packet/af_packet.c:2894 [inline]
  packet_sendmsg+0x6444/0x8a10 net/packet/af_packet.c:2969
  sock_sendmsg_nosec net/socket.c:630 [inline]
  sock_sendmsg net/socket.c:640 [inline]
  sock_write_iter+0x3b9/0x470 net/socket.c:909
  do_iter_readv_writev+0x7bb/0x970 include/linux/fs.h:1776
  do_iter_write+0x30d/0xd40 fs/read_write.c:932
  vfs_writev fs/read_write.c:977 [inline]
  do_writev+0x3c9/0x830 fs/read_write.c:1012
  SYSC_writev+0x9b/0xb0 fs/read_write.c:1085
  SyS_writev+0x56/0x80 fs/read_write.c:1082
  do_syscall_64+0x309/0x430 arch/x86/entry/common.c:287
  entry_SYSCALL_64_after_hwframe+0x3d/0xa2

Fixes: 58e998c6d2 ("offloading: Force software GSO for multiple vlan tags.")
Reported-and-tested-by: syzbot+0bbe42c764feafa82c5a@syzkaller.appspotmail.com
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-04-29 07:50:05 +02:00
..
…
…
2015-10-17 21:22:08 -07:00
…
…
…
…
…
…
…
…
…
…
…
…
…
…
…
2015-03-25 20:28:11 -04:00
2005-04-16 15:20:36 -07:00
2016-03-09 15:34:52 -08:00
…
2012-12-02 00:05:12 +00:00
2018-04-08 11:51:57 +02:00
…
2018-04-24 09:32:12 +02:00
2011-03-11 14:25:50 +00:00
…
2009-11-20 20:13:39 +01:00
…
2017-06-14 13:16:23 +02:00
…
2013-11-15 09:32:21 +09:00
…
…
2018-01-17 09:35:33 +01:00
…
2008-12-25 11:01:43 +11:00
2015-02-12 18:54:15 -08:00
…
2015-09-08 15:35:28 -07:00
2017-08-06 19:19:42 -07:00
2011-01-10 08:51:44 -08:00
2015-10-18 10:14:39 -07:00
2010-08-04 11:00:45 +02:00
2012-02-20 19:46:36 +11:00
2014-11-10 09:27:30 -07:00
2009-09-14 17:41:42 -07:00
…
2012-10-16 18:49:15 -07:00
…
…
2013-05-07 18:38:27 -07:00
…
…
…
…
2017-07-15 11:57:44 +02:00
2014-12-31 13:06:50 -05:00
2015-10-30 01:47:27 -04:00
2018-01-17 09:35:30 +01:00
2014-10-09 11:35:48 +03:00
2015-06-24 17:49:45 -07:00
…
…
…
2017-08-06 19:19:42 -07:00
2009-06-18 13:04:05 -07:00
…
2014-08-06 18:01:24 -07:00
2015-05-12 10:46:53 +02:00
…
…
2018-04-24 09:32:07 +02:00
…
2010-02-09 11:13:56 +01:00
…
2010-03-07 22:17:09 +01:00
…
…
…
…
…
2011-07-01 10:37:15 +02:00
2015-05-05 13:40:42 -06:00
2014-06-06 16:08:13 -07:00
…
…
…
…
…
…
…
2008-08-02 18:36:10 +01:00
2005-04-16 15:20:36 -07:00
2015-08-27 19:40:58 -04:00
2006-10-10 15:37:22 -07:00
2012-03-20 12:47:48 +01:00
…
…
…
…
2013-06-17 16:38:57 -07:00
…
…
2014-03-13 12:11:00 +10:30
…
…
…
2016-10-28 03:01:30 -04:00
2015-08-18 15:49:15 -07:00
…
2011-01-24 14:45:11 +10:30
2008-07-04 10:40:05 -07:00
…
2011-09-16 19:20:20 -04:00
…
…
2015-11-23 09:44:58 +01:00
…
…
2014-05-27 17:38:11 -07:00
2013-12-26 13:29:35 -05:00
…
…
…
2015-04-14 16:49:05 -07:00
2015-10-27 18:55:31 -07:00
2015-10-20 22:10:45 +08:00
2014-03-04 13:51:06 -05:00
…
2014-01-27 21:02:39 -08:00
…
…
2015-06-25 04:20:04 -04:00
…
…
2014-01-25 03:14:05 -05:00
2012-12-11 17:22:27 -08:00
…
…
…
…
…
…
…
…
…
…
2015-11-06 17:50:42 -08:00
…
…
…
…
2016-12-08 07:15:24 +01:00
2014-07-09 14:58:37 +01:00
2015-04-12 21:03:31 +02:00
2017-08-24 17:02:36 -07:00
…
…
…
2015-10-09 17:00:32 -04:00
2013-10-17 00:36:06 +02:00
2011-11-02 16:07:02 -07:00
2011-03-31 11:26:23 -03:00
…
…
…
…
…
…
…
…
…
…
2015-05-26 15:23:23 +02:00
2010-05-11 10:09:47 +02:00
2015-06-25 01:13:43 +02:00
2013-06-17 16:38:57 -07:00
…
…
…
…
2014-08-08 15:57:26 -07:00
…
…
…
…
2015-04-11 15:53:35 -04:00
…
2014-06-12 00:21:11 -04:00
2010-08-09 16:48:44 -04:00
…
2013-04-30 15:50:12 +05:30
…
2014-06-04 16:53:57 -07:00
…
2005-04-16 15:20:36 -07:00
2015-06-25 17:00:39 -07:00
…
…
2018-01-31 12:06:13 +01:00
…
2016-04-12 09:08:35 -07:00
2015-08-17 11:25:28 -07:00
2015-10-01 09:57:59 -07:00
…
…
2015-10-19 01:01:21 +02:00
…
…
…
2005-04-16 15:20:36 -07:00
2014-11-28 16:08:16 +01:00
2005-04-16 15:20:36 -07:00
…
…
2014-04-07 16:35:53 -07:00
…
…
…
2015-12-13 14:30:59 -08:00
2015-03-24 09:48:14 -07:00
…
2015-11-13 20:34:33 -05:00
2011-01-13 08:03:24 -08:00
2013-10-17 15:53:09 -04:00
2015-09-08 15:35:28 -07:00
…