Dongliang Mu
2c2fb2df46
NFC: nci: fix memory leak in nci_allocate_device
commit e0652f8bb4 upstream.
nfcmrvl_disconnect fails to free the hci_dev field in struct nci_dev.
Fix this by freeing hci_dev in nci_free_device.
BUG: memory leak
unreferenced object 0xffff888111ea6800 (size 1024):
comm "kworker/1:0", pid 19, jiffies 4294942308 (age 13.580s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 60 fd 0c 81 88 ff ff .........`......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000004bc25d43>] kmalloc include/linux/slab.h:552 [inline]
[<000000004bc25d43>] kzalloc include/linux/slab.h:682 [inline]
[<000000004bc25d43>] nci_hci_allocate+0x21/0xd0 net/nfc/nci/hci.c:784
[<00000000c59cff92>] nci_allocate_device net/nfc/nci/core.c:1170 [inline]
[<00000000c59cff92>] nci_allocate_device+0x10b/0x160 net/nfc/nci/core.c:1132
[<00000000006e0a8e>] nfcmrvl_nci_register_dev+0x10a/0x1c0 drivers/nfc/nfcmrvl/main.c:153
[<000000004da1b57e>] nfcmrvl_probe+0x223/0x290 drivers/nfc/nfcmrvl/usb.c:345
[<00000000d506aed9>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
[<00000000bc632c92>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
[<00000000f5009125>] driver_probe_device+0x84/0x100 drivers/base/dd.c:740
[<000000000ce658ca>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:846
[<000000007067d05f>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
[<00000000f8e13372>] __device_attach+0x122/0x250 drivers/base/dd.c:914
[<000000009cf68860>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
[<00000000359c965a>] device_add+0x5be/0xc30 drivers/base/core.c:3109
[<00000000086e4bd3>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
[<00000000ca036872>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
[<00000000d40d36f6>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
[<00000000bc632c92>] really_probe+0x159/0x4a0 drivers/base/dd.c:554
Reported-by: syzbot+19bcfc64a8df1318d1c3@syzkaller.appspotmail.com
Fixes: 11f54f2286 ("NFC: nci: Add HCI over NCI protocol support")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-03 08:36:11 +02:00
..
2021-05-22 10:57:24 +02:00
2019-05-08 07:20:45 +02:00
2020-09-09 19:03:08 +02:00
2019-06-17 19:52:44 +02:00
2021-06-03 08:36:11 +02:00
2019-03-23 14:35:16 +01:00
2020-06-30 15:37:59 -04:00
2019-05-04 09:15:20 +02:00
2020-06-03 08:17:33 +02:00
2020-08-21 09:48:00 +02:00
2019-08-04 09:31:59 +02:00
2019-06-11 12:21:51 +02:00
2019-02-23 09:06:44 +01:00
2020-12-08 10:17:33 +01:00
2019-11-10 11:25:24 +01:00
2020-02-05 14:18:21 +00:00
2020-01-04 14:00:14 +01:00
2020-07-22 09:22:20 +02:00
2020-03-20 10:54:10 +01:00
2020-03-11 18:02:48 +01:00
2019-11-10 11:25:37 +01:00
2019-11-10 11:25:37 +01:00
2020-07-22 09:22:19 +02:00
2021-03-03 18:22:57 +01:00
2020-08-21 09:48:14 +02:00
2020-12-11 13:39:03 +01:00
2019-04-27 09:35:40 +02:00
2020-01-04 14:00:19 +01:00
2019-02-23 09:06:42 +01:00
2019-06-11 12:21:47 +02:00
2020-04-24 08:00:53 +02:00
2019-07-21 09:04:28 +02:00
2019-01-31 08:13:42 +01:00
2020-08-21 09:48:08 +02:00
2020-10-29 09:06:58 +01:00
2019-09-16 08:20:44 +02:00
2020-05-20 08:17:02 +02:00
2019-02-06 17:31:33 +01:00
2019-11-06 12:43:36 +01:00
2019-11-20 17:59:59 +01:00
2020-01-09 10:17:59 +01:00
2019-04-17 08:37:50 +02:00
2019-09-10 10:32:21 +01:00
2021-04-16 11:57:49 +02:00
2020-01-27 14:46:50 +01:00
2021-03-30 14:40:12 +02:00
2019-11-06 12:43:39 +01:00
2020-08-21 09:48:18 +02:00
2021-02-03 23:22:23 +01:00
2020-10-14 09:51:12 +02:00