Pavel Skripkin 8121d0d4fd Revert "net: mdiobus: Fix memory leak in __mdiobus_register" ...

commit 10eff1f578 upstream.

This reverts commit ab609f25d1.

This patch is correct in the sense that we _should_ call device_put() in
case of device_register() failure, but the problem in this code is more
vast.

We need to set bus->state to UNMDIOBUS_REGISTERED before calling
device_register() to correctly release the device in mdiobus_free().
This patch prevents us from doing it, since in case of device_register()
failure put_device() will be called 2 times and it will cause UAF or
something else.

Also, Reported-by: tag in revered commit was wrong, since syzbot
reported different leak in same function.

Link: https://lore.kernel.org/netdev/20210928092657.GI2048@kadam/
Acked-by: Yanfei Xu <yanfei.xu@windriver.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/f12fb1faa4eccf0f355788225335eb4309ff2599.1633024062.git.paskripkin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-11-02 18:26:44 +01:00

..

amd.c

…

aquantia.c

…

at803x.c

…

ax88796b.c

…

bcm7xxx.c

net: phy: bcm7xxx: Fixed indirect MMD operations

2021-10-17 10:19:48 +02:00

bcm63xx.c

…

bcm87xx.c

…

bcm-cygnus.c

…

bcm-phy-lib.c

net: phy: broadcom: Only advertise EEE for supported modes

2021-04-16 11:49:30 +02:00

bcm-phy-lib.h

…

broadcom.c

…

cicada.c

…

cortina.c

…

davicom.c

…

dp83tc811.c

…

dp83640_reg.h

ptp: dp83640: don't define PAGE0

2021-09-22 11:48:11 +02:00

dp83640.c

net: dp83640: fix SIOCSHWTSTAMP to update the struct with actual configuration

2020-07-29 10:16:49 +02:00

dp83822.c

…

dp83848.c

…

dp83867.c

net: phy: dp83867: enable robust auto-mdix

2019-12-31 16:35:27 +01:00

et1011c.c

…

fixed_phy.c

net: phy: fixed_phy: Fix fixed_phy not checking GPIO

2020-01-27 14:50:20 +01:00

icplus.c

…

intel-xway.c

…

Kconfig

mdio: fix mdio-thunder.c dependency & build error

2020-10-14 10:31:25 +02:00

lxt.c

…

Makefile

…

marvell10g.c

…

marvell.c

net: phy: marvell: fix detection of PHY on Topaz switches

2021-04-28 13:16:51 +02:00

mdio_bus.c

Revert "net: mdiobus: Fix memory leak in __mdiobus_register"

2021-11-02 18:26:44 +01:00

mdio_device.c

net: mdio: introduce a shutdown method to mdio device drivers

2021-10-09 14:11:03 +02:00

mdio-bcm-iproc.c

net: phy: restore mdio regs in the iproc mdio driver

2020-03-05 16:42:16 +01:00

mdio-bcm-unimac.c

…

mdio-bitbang.c

…

mdio-boardinfo.c

…

mdio-boardinfo.h

…

mdio-cavium.c

…

mdio-cavium.h

…

mdio-gpio.c

…

mdio-hisi-femac.c

…

mdio-i2c.c

…

mdio-i2c.h

…

mdio-moxart.c

…

mdio-mscc-miim.c

…

mdio-mux-bcm-iproc.c

net: phy: mdio-mux-bcm-iproc: check clk_prepare_enable() return value

2020-04-02 15:28:13 +02:00

mdio-mux-gpio.c

…

mdio-mux-mmioreg.c

…

mdio-mux.c

net: mdio-mux: Handle -EPROBE_DEFER correctly

2021-08-26 08:36:47 -04:00

mdio-octeon.c

net: mdio: octeon: Fix some double free issues

2021-06-03 08:38:11 +02:00

mdio-sun4i.c

…

mdio-thunder.c

net: mdio: thunder: Fix a double free issue in the .remove function

2021-06-03 08:38:11 +02:00

mdio-xgene.c

…

mdio-xgene.h

…

meson-gxl.c

…

micrel.c

net: phy: micrel: kszphy_resume(): add delay after genphy_resume() before accessing PHY registers

2020-04-13 10:45:08 +02:00

microchip_t1.c

…

microchip.c

…

mscc.c

…

national.c

…

phy_device.c

net: phy: Avoid NPD upon phy_detach() when driver is unbound

2020-09-26 18:01:30 +02:00

phy_led_triggers.c

…

phy-c45.c

…

phy-core.c

…

phy.c

net: phy: fix save wrong speed and duplex problem if autoneg is on

2021-03-17 16:43:45 +01:00

phylink.c

…

qsemi.c

…

realtek.c

…

rockchip.c

…

sfp-bus.c

net: sfp: add some quirks for GPON modules

2020-07-22 09:32:03 +02:00

sfp.c

net: sfp: Fix typo in state machine debug string

2021-10-13 10:10:52 +02:00

sfp.h

…

smsc.c

…

spi_ks8995.c

…

ste10Xp.c

…

swphy.c

…

swphy.h

…

teranetics.c

…

uPD60620.c

…

vitesse.c

…

xilinx_gmii2rgmii.c

…