Oleg Nesterov
d0bc74c563
cgroup/pids: turn cgroup_subsys->free() into cgroup_subsys->release() to fix the accounting
...
[ Upstream commit 51bee5abea ]
The only user of cgroup_subsys->free() callback is pids_cgrp_subsys which
needs pids_free() to uncharge the pid.
However, ->free() is called from __put_task_struct()->cgroup_free() and this
is too late. Even the trivial program which does
for (;;) {
int pid = fork();
assert(pid >= 0);
if (pid)
wait(NULL);
else
exit(0);
}
can run out of limits because release_task()->call_rcu(delayed_put_task_struct)
implies an RCU gp after the task/pid goes away and before the final put().
Test-case:
mkdir -p /tmp/CG
mount -t cgroup2 none /tmp/CG
echo '+pids' > /tmp/CG/cgroup.subtree_control
mkdir /tmp/CG/PID
echo 2 > /tmp/CG/PID/pids.max
perl -e 'while ($p = fork) { wait; } $p // die "fork failed: $!\n"' &
echo $! > /tmp/CG/PID/cgroup.procs
Without this patch the forking process fails soon after migration.
Rename cgroup_subsys->free() to cgroup_subsys->release() and move the callsite
into the new helper, cgroup_release(), called by release_task() which actually
frees the pid(s).
Reported-by: Herton R. Krzesinski <hkrzesin@redhat.com >
Reported-by: Jan Stancek <jstancek@redhat.com >
Signed-off-by: Oleg Nesterov <oleg@redhat.com >
Signed-off-by: Tejun Heo <tj@kernel.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2019-04-05 22:33:13 +02:00
..
2019-01-22 21:40:33 +01:00
2018-12-01 09:37:29 +01:00
2019-03-27 14:14:39 +09:00
2018-08-18 15:55:59 -07:00
2018-09-30 08:49:55 -07:00
2019-02-12 19:46:57 +01:00
2019-03-13 14:02:35 -07:00
2018-09-10 16:58:36 +01:00
2019-02-12 19:47:01 +01:00
2019-02-20 10:25:46 +01:00
2018-11-27 16:13:05 +01:00
2019-01-13 09:50:57 +01:00
2018-10-12 15:25:17 +01:00
2018-08-26 17:45:25 -07:00
2019-02-27 10:08:52 +01:00
2018-09-03 16:10:40 +01:00
2019-04-05 22:33:09 +02:00
2018-08-23 13:44:43 -07:00
2018-09-28 18:04:06 -07:00
2019-02-15 08:10:13 +01:00
2019-01-26 09:32:34 +01:00
2018-08-22 08:08:27 -07:00
2018-08-30 14:18:03 +01:00
2019-03-05 17:58:50 +01:00
2018-08-22 10:52:46 -07:00
2018-08-17 16:20:27 -07:00
2018-08-22 10:52:48 -07:00
2018-08-31 14:48:56 -06:00
2018-08-14 10:23:25 -07:00
2018-09-11 10:59:53 -06:00
2019-01-31 08:14:41 +01:00
2018-08-13 00:52:45 +02:00
2019-04-05 22:33:13 +02:00
2019-04-05 22:33:13 +02:00
2019-04-05 22:33:03 +02:00
2018-08-17 16:20:32 -07:00
2018-11-13 11:08:25 -08:00
2018-09-20 15:23:58 +02:00
2019-02-27 10:08:53 +01:00
2019-02-27 10:08:53 +01:00
2019-02-27 10:08:53 +01:00
2019-02-27 10:08:53 +01:00
2019-02-12 19:47:25 +01:00
2019-03-10 07:17:15 +01:00
2018-08-23 13:44:43 -07:00
2018-08-13 09:05:05 -07:00
2018-08-22 10:52:46 -07:00
2018-08-22 10:52:48 -07:00
2018-08-21 18:19:09 -07:00
2019-03-23 20:10:09 +01:00
2019-04-03 06:26:30 +02:00
2018-08-17 16:20:32 -07:00
2018-08-25 13:40:38 -07:00
2019-04-05 22:32:59 +02:00
2019-04-05 22:33:12 +02:00
2018-11-13 11:08:50 -08:00
2018-12-17 09:24:38 +01:00
2018-12-01 09:37:31 +01:00
2018-12-05 19:32:10 +01:00
2019-01-22 21:40:35 +01:00
2019-02-12 19:47:14 +01:00
2018-08-23 18:48:43 -07:00
2019-03-23 20:10:08 +01:00
2018-11-13 11:08:54 -08:00
2019-02-12 19:47:24 +01:00
2018-12-05 19:32:13 +01:00
2018-09-04 21:31:43 +02:00
2019-01-13 09:51:04 +01:00
2018-10-18 11:30:52 +02:00
2018-10-05 16:32:04 -07:00
2019-01-31 08:14:36 +01:00
2018-08-30 23:13:15 +02:00
2018-11-21 09:19:20 +01:00
2018-08-26 11:48:42 -07:00
2019-03-05 17:58:51 +01:00
2018-08-15 10:25:26 -07:00
2018-08-22 10:52:47 -07:00
2018-08-22 10:52:52 -07:00
2019-03-05 17:58:45 +01:00
2019-04-05 22:33:09 +02:00
2018-08-16 19:36:55 +02:00
2018-08-17 16:20:30 -07:00
2018-08-26 11:25:21 -07:00
2018-08-22 10:52:46 -07:00
2019-03-23 20:09:48 +01:00
2018-08-18 11:44:53 -07:00
2019-03-23 20:10:13 +01:00
2018-08-24 13:20:33 -07:00
2018-08-17 16:20:32 -07:00
2018-08-15 10:25:26 -07:00
2018-12-29 13:37:59 +01:00
2018-08-22 10:52:45 -07:00
2018-08-22 10:52:45 -07:00
2019-01-13 09:51:04 +01:00
2018-09-13 15:18:04 -10:00
2018-09-13 15:18:04 -10:00
2018-12-29 13:37:57 +01:00
2018-08-22 10:52:44 -07:00
2018-10-09 08:30:51 +02:00
2018-09-05 14:36:53 +02:00
2019-01-16 22:04:29 +01:00
2019-01-09 17:38:42 +01:00
2018-12-05 19:31:59 +01:00
2019-02-23 09:07:25 +01:00
2019-02-06 17:30:06 +01:00
2018-09-28 14:47:40 +02:00
2018-09-23 21:55:24 -07:00
2018-08-23 16:03:58 -07:00
2018-08-13 17:04:23 -04:00
2018-11-21 09:19:20 +01:00
2018-08-17 16:20:29 -07:00
2018-08-22 10:52:45 -07:00
2018-11-13 11:08:24 -08:00
2019-02-06 17:30:15 +01:00
2018-08-23 18:48:44 -07:00
2018-08-17 16:20:28 -07:00
2018-08-23 18:48:43 -07:00
2018-09-03 19:05:13 -07:00
2018-09-11 21:44:52 -05:00
2018-08-22 10:52:45 -07:00
2019-04-05 22:33:11 +02:00
2018-12-01 09:37:34 +01:00
2019-03-23 20:09:59 +01:00
2018-08-14 13:36:15 +02:00
2018-08-22 10:52:46 -07:00
2019-03-23 20:10:04 +01:00
2018-12-17 09:24:39 +01:00
2019-01-09 17:38:33 +01:00
2018-12-05 19:32:03 +01:00
2018-08-22 18:17:29 +02:00
2019-04-05 22:32:56 +02:00
2019-04-05 22:32:56 +02:00
2019-04-05 22:33:12 +02:00
2018-08-15 10:25:26 -07:00
2018-10-02 14:38:02 -07:00
2018-08-20 09:22:45 -07:00
2018-08-22 10:52:43 -07:00
2018-11-13 11:08:45 -08:00
2019-03-23 20:10:06 +01:00
2019-04-03 06:26:28 +02:00
2018-08-16 12:14:42 -07:00
2019-03-13 14:02:35 -07:00
2018-10-12 12:35:02 +02:00
2019-01-26 09:32:43 +01:00
2018-08-23 18:48:44 -07:00
2018-08-14 16:39:13 -07:00
2018-08-18 11:44:53 -07:00
2018-12-29 13:37:55 +01:00
2018-11-13 11:08:51 -08:00
2018-12-05 19:32:00 +01:00
2018-08-22 15:11:35 +02:00
2018-09-03 13:26:44 +02:00
2018-10-17 15:35:29 -04:00
2018-12-08 12:59:07 +01:00
2018-12-13 09:16:15 +01:00
2018-09-12 14:58:47 -07:00
2018-08-13 20:08:33 -04:00
2018-12-13 09:16:15 +01:00
2018-08-23 18:48:44 -07:00
2018-08-16 09:57:20 -07:00
2018-09-13 17:58:30 +02:00
2019-02-27 10:09:01 +01:00
2018-09-13 15:18:04 -10:00
2018-09-13 15:18:04 -10:00
2018-11-13 11:08:42 -08:00