net: bcmgenet: Ensure MDIO unregistration has clocks enabled

commit 1b5ea7ffb7 upstream.

With support for Ethernet PHY LEDs having been added, while
unregistering a MDIO bus and its child device liks PHYs there may be
"late" accesses to the MDIO bus. One typical use case is setting the PHY
LEDs brightness to OFF for instance.

We need to ensure that the MDIO bus controller remains entirely
functional since it runs off the main GENET adapter clock.

Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20230617155500.4005881-1-andrew@lunn.ch/
Fixes: 9a4e796970 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230622103107.1760280-1-florian.fainelli@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

Florian Fainelli

2023-06-22 03:31:07 -07:00

committed by

Greg Kroah-Hartman

parent 21d5d3eb36

commit fe1ae1fb50

1 changed files with 2 additions and 0 deletions

									
										drivers/net/ethernet/broadcom/genet/bcmmii.c
									
		+2
		
												View File
												
				@@ -624,5 +624,7 @@ void bcmgenet_mii_exit(struct net_device *dev)

					if (of_phy_is_fixed_link(dn))

						of_phy_deregister_fixed_link(dn);

					of_node_put(priv->phy_dn);

					clk_prepare_enable(priv->clk);

					platform_device_unregister(priv->mii_pdev);

					clk_disable_unprepare(priv->clk);

				}