From fc64efcd068c9f723ff047f32c1c1302ad146469 Mon Sep 17 00:00:00 2001 From: Elliot Berman Date: Tue, 8 Feb 2022 12:38:49 -0800 Subject: [PATCH] Revert "UPSTREAM: tracefs: Have tracefs directories not set OTH permission bits by default" This reverts commit 9c63be2adac9788180d892351052b9f2bcdb3d37. Reason for revert: android12 still relies on OTH bits being set. Bug: 218458907 Signed-off-by: Elliot Berman Change-Id: Idac3d9a515188d718b7bf5c01105531f2e9bacdc --- fs/tracefs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c index ade05887070d..5a3f09d7d821 100644 --- a/fs/tracefs/inode.c +++ b/fs/tracefs/inode.c @@ -504,8 +504,7 @@ static struct dentry *__create_dir(const char *name, struct dentry *parent, if (unlikely(!inode)) return failed_creating(dentry); - /* Do not set bits for OTH */ - inode->i_mode = S_IFDIR | S_IRWXU | S_IRUSR| S_IRGRP | S_IXUSR | S_IXGRP; + inode->i_mode = S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO; inode->i_op = ops; inode->i_fop = &simple_dir_operations; inode->i_uid = d_inode(dentry->d_parent)->i_uid;