TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bpftool: fix potential NULL pointer dereferencing in prog_dump()

Browse Source 
A NULL pointer dereference could occur if ksyms
is not properly checked before usage in the prog_dump() function.

Fixes: b053b439b7 ("bpf: libbpf: bpftool: Print bpf_line_info during prog dump")
Signed-off-by: Amir Mohammadi <amiremohamadi@yahoo.com>
Reviewed-by: Quentin Monnet <qmo@kernel.org>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/r/20241121083413.7214-1-amiremohamadi@yahoo.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This commit is contained in:
Amir Mohammadi
2024-11-21 12:04:13 +03:30
committed by Alexei Starovoitov
parent ac9a48a6f1
commit ef3ba8c258
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/bpf/bpftool/prog.c
+12 -5
View File
@@ -822,11 +822,18 @@ prog_dump(struct bpf_prog_info *info, enum dump_mode mode,
printf("%s:\n", sym_name); printf("%s:\n", sym_name);
} }
if (disasm_print_insn(img, lens[i], opcodes, if (ksyms) {
name, disasm_opt, btf, if (disasm_print_insn(img, lens[i], opcodes,
prog_linfo, ksyms[i], i, name, disasm_opt, btf,
linum)) prog_linfo, ksyms[i], i,
goto exit_free; linum))
goto exit_free;
} else {
if (disasm_print_insn(img, lens[i], opcodes,
name, disasm_opt, btf,
NULL, 0, 0, false))
goto exit_free;
}
img += lens[i]; img += lens[i];