TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group()

Browse Source 
This code is intended to reject strings that start with "_sysfs" but the
strcmp() limit is wrong so checks the whole string instead of the prefix.

Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Koichiro Den <koichiro.den@canonical.com>
Link: https://lore.kernel.org/r/30210ed77b40b4b6629de659cb56b9ec7832c447.1744452787.git.dan.carpenter@linaro.org
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
This commit is contained in:
Dan Carpenter 2025-04-12 13:15:00 +03:00 committed by Bartosz Golaszewski
parent 6d7f0c1103
commit eebfcb98cd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpio-aggregator.c
View File

@ -1016,7 +1016,7 @@ gpio_aggregator_make_group(struct config_group *group, const char *name)
* for devices create via legacy sysfs interface.
*/
if (strncmp(name, AGGREGATOR_LEGACY_PREFIX,
sizeof(AGGREGATOR_LEGACY_PREFIX)) == 0)
sizeof(AGGREGATOR_LEGACY_PREFIX) - 1) == 0)
return ERR_PTR(-EINVAL);
/* arg space is unneeded */