TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: gadget: f_hid: fix refcount leak on error path

Browse Source 
[ Upstream commit 70a3288a75 ]

When failing to allocate report_desc, opts->refcnt has already been
incremented so it needs to be decremented to avoid leaving the options
structure permanently locked.

Fixes: 21a9476a7b ("usb: gadget: hid: add configfs support")
Tested-by: Lee Jones <lee@kernel.org>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Reviewed-by: Lee Jones <lee@kernel.org>
Signed-off-by: John Keeping <john@metanate.com>
Link: https://lore.kernel.org/r/20221122123523.3068034-3-john@metanate.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
John Keeping
2022-11-22 12:35:22 +00:00
committed by Greg Kroah-Hartman
parent 1b6a53e447
commit e88b89a096
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/usb/gadget/function/f_hid.c
+1
View File
@@ -1292,6 +1292,7 @@ static struct usb_function *hidg_alloc(struct usb_function_instance *fi)
GFP_KERNEL); GFP_KERNEL);
if (!hidg->report_desc) { if (!hidg->report_desc) {
put_device(&hidg->dev); put_device(&hidg->dev);
--opts->refcnt;
mutex_unlock(&opts->lock); mutex_unlock(&opts->lock);
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }