Lockd: pass network namespace to creation and destruction routines
v2: dereference of most probably already released nlm_host removed in nlmclnt_done() and reclaimer(). These routines are called from locks reclaimer() kernel thread. This thread works in "init_net" network context and currently relays on persence on lockd thread and it's per-net resources. Thus lockd_up() and lockd_down() can't relay on current network context. So let's pass corrent one into them. Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
committed by
J. Bruce Fields
parent
f890edbbef
commit
e3f70eadb7
+8
-5
@@ -56,7 +56,7 @@ struct nlm_host *nlmclnt_init(const struct nlmclnt_initdata *nlm_init)
|
||||
u32 nlm_version = (nlm_init->nfs_version == 2) ? 1 : 4;
|
||||
int status;
|
||||
|
||||
status = lockd_up();
|
||||
status = lockd_up(nlm_init->net);
|
||||
if (status < 0)
|
||||
return ERR_PTR(status);
|
||||
|
||||
@@ -65,7 +65,7 @@ struct nlm_host *nlmclnt_init(const struct nlmclnt_initdata *nlm_init)
|
||||
nlm_init->hostname, nlm_init->noresvport,
|
||||
nlm_init->net);
|
||||
if (host == NULL) {
|
||||
lockd_down();
|
||||
lockd_down(nlm_init->net);
|
||||
return ERR_PTR(-ENOLCK);
|
||||
}
|
||||
|
||||
@@ -80,8 +80,10 @@ EXPORT_SYMBOL_GPL(nlmclnt_init);
|
||||
*/
|
||||
void nlmclnt_done(struct nlm_host *host)
|
||||
{
|
||||
struct net *net = host->net;
|
||||
|
||||
nlmclnt_release_host(host);
|
||||
lockd_down();
|
||||
lockd_down(net);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(nlmclnt_done);
|
||||
|
||||
@@ -220,11 +222,12 @@ reclaimer(void *ptr)
|
||||
struct nlm_wait *block;
|
||||
struct file_lock *fl, *next;
|
||||
u32 nsmstate;
|
||||
struct net *net = host->net;
|
||||
|
||||
allow_signal(SIGKILL);
|
||||
|
||||
down_write(&host->h_rwsem);
|
||||
lockd_up(); /* note: this cannot fail as lockd is already running */
|
||||
lockd_up(net); /* note: this cannot fail as lockd is already running */
|
||||
|
||||
dprintk("lockd: reclaiming locks for host %s\n", host->h_name);
|
||||
|
||||
@@ -275,6 +278,6 @@ restart:
|
||||
|
||||
/* Release host handle after use */
|
||||
nlmclnt_release_host(host);
|
||||
lockd_down();
|
||||
lockd_down(net);
|
||||
return 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user