TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_ethtool.c

Browse Source 
Add error pointer check after calling otx2_mbox_get_rsp().

Fixes: 75f3627099 ("octeontx2-pf: Support to enable/disable pause frames via ethtool")
Fixes: d0cf9503e9 ("octeontx2-pf: ethtool fec mode support")
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
This commit is contained in:
Dipendra Khadka
2024-10-17 19:02:29 +00:00
committed by Andrew Lunn
parent 0fbc7a5027
commit e26f8eac6b
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
+10
View File
@@ -343,6 +343,11 @@ static void otx2_get_pauseparam(struct net_device *netdev,
if (!otx2_sync_mbox_msg(&pfvf->mbox)) { if (!otx2_sync_mbox_msg(&pfvf->mbox)) {
rsp = (struct cgx_pause_frm_cfg *) rsp = (struct cgx_pause_frm_cfg *)
otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr); otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
if (IS_ERR(rsp)) {
mutex_unlock(&pfvf->mbox.lock);
return;
}
pause->rx_pause = rsp->rx_pause; pause->rx_pause = rsp->rx_pause;
pause->tx_pause = rsp->tx_pause; pause->tx_pause = rsp->tx_pause;
} }
@@ -1072,6 +1077,11 @@ static int otx2_set_fecparam(struct net_device *netdev,
rsp = (struct fec_mode *)otx2_mbox_get_rsp(&pfvf->mbox.mbox, rsp = (struct fec_mode *)otx2_mbox_get_rsp(&pfvf->mbox.mbox,
0, &req->hdr); 0, &req->hdr);
if (IS_ERR(rsp)) {
err = PTR_ERR(rsp);
goto end;
}
if (rsp->fec >= 0) if (rsp->fec >= 0)
pfvf->linfo.fec = rsp->fec; pfvf->linfo.fec = rsp->fec;
else else