TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: jme: Replace mdelay() with msleep() and usleep_range() in jme_wait_link()

Browse Source 
jme_wait_link() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep() and usleep_range().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jia-Ju Bai
2018-07-27 16:25:07 +08:00
committed by David S. Miller
parent 89036f233a
commit d818c59a8f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ethernet/jme.c
+2 -2
View File
@@ -1911,10 +1911,10 @@ jme_wait_link(struct jme_adapter *jme)
{ {
u32 phylink, to = JME_WAIT_LINK_TIME; u32 phylink, to = JME_WAIT_LINK_TIME;
mdelay(1000); msleep(1000);
phylink = jme_linkstat_from_phy(jme); phylink = jme_linkstat_from_phy(jme);
while (!(phylink & PHY_LINK_UP) && (to -= 10) > 0) { while (!(phylink & PHY_LINK_UP) && (to -= 10) > 0) {
mdelay(10); usleep_range(10000, 11000);
phylink = jme_linkstat_from_phy(jme); phylink = jme_linkstat_from_phy(jme);
} }
} }