TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/fsl: xgmac_mdio: Fix incorrect iounmap when removing module

Browse Source 
commit 3f7c239c78 upstream.

As reported by sparse: In the remove path, the driver would attempt to
unmap its own priv pointer - instead of the io memory that it mapped
in probe.

Fixes: 9f35a7342c ("net/fsl: introduce Freescale 10G MDIO driver")
Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tobias Waldekranz
2022-01-18 22:50:53 +01:00
committed by Greg Kroah-Hartman
parent 38c798384b
commit d806eb5f4e
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ethernet/freescale/xgmac_mdio.c
+2 -1
View File
@@ -320,9 +320,10 @@ err_ioremap:
static int xgmac_mdio_remove(struct platform_device *pdev) static int xgmac_mdio_remove(struct platform_device *pdev)
{ {
struct mii_bus *bus = platform_get_drvdata(pdev); struct mii_bus *bus = platform_get_drvdata(pdev);
struct mdio_fsl_priv *priv = bus->priv;
mdiobus_unregister(bus); mdiobus_unregister(bus);
iounmap(bus->priv); iounmap(priv->mdio_base);
mdiobus_free(bus); mdiobus_free(bus);
return 0; return 0;