TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: phy: use of_mdio_parse_addr

Browse Source 
use of_mdio_parse_addr() in place of an OF read of reg and a bounds
check (which is litterally the exact same thing that
of_mdio_parse_addr() does)

Signed-off-by: Jon Mason <jon.mason@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jon Mason
2017-05-31 15:43:30 -04:00
committed by David S. Miller
parent 775e68a93f
commit d0a65400eb
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/phy/mdio_bus.c
+2 -13
View File
@@ -263,21 +263,10 @@ static void of_mdiobus_link_mdiodev(struct mii_bus *bus,
for_each_available_child_of_node(bus->dev.of_node, child) { for_each_available_child_of_node(bus->dev.of_node, child) {
int addr; int addr;
int ret;
ret = of_property_read_u32(child, "reg", &addr); addr = of_mdio_parse_addr(dev, child);
if (ret < 0) { if (addr < 0)
dev_err(dev, "%s has invalid MDIO address\n",
child->full_name);
continue; continue;
}
/* A MDIO device must have a reg property in the range [0-31] */
if (addr >= PHY_MAX_ADDR) {
dev_err(dev, "%s MDIO address %i is too large\n",
child->full_name, addr);
continue;
}
if (addr == mdiodev->addr) { if (addr == mdiodev->addr) {
dev->of_node = child; dev->of_node = child;