TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

9p/xen: Fix end of loop tests for list_for_each_entry

Browse Source 
commit 732b33d0db upstream.

This patch addresses the following problems:
 - priv can never be NULL, so this part of the check is useless
 - if the loop ran through the whole list, priv->client is invalid and
it is more appropriate and sufficient to check for the end of
list_for_each_entry loop condition.

Link: http://lkml.kernel.org/r/20210727000709.225032-1-harshvardhan.jha@oracle.com
Signed-off-by: Harshvardhan Jha <harshvardhan.jha@oracle.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Tested-by: Stefano Stabellini <sstabellini@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Harshvardhan Jha
2021-07-27 05:37:10 +05:30
committed by Greg Kroah-Hartman
parent 907944851a
commit c37085d606
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/9p/trans_xen.c
+2 -2
View File
@@ -138,7 +138,7 @@ static bool p9_xen_write_todo(struct xen_9pfs_dataring *ring, RING_IDX size)
static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req) static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req)
{ {
struct xen_9pfs_front_priv *priv = NULL; struct xen_9pfs_front_priv *priv;
RING_IDX cons, prod, masked_cons, masked_prod; RING_IDX cons, prod, masked_cons, masked_prod;
unsigned long flags; unsigned long flags;
u32 size = p9_req->tc.size; u32 size = p9_req->tc.size;
@@ -151,7 +151,7 @@ static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req)
break; break;
} }
read_unlock(&xen_9pfs_lock); read_unlock(&xen_9pfs_lock);
if (!priv || priv->client != client) if (list_entry_is_head(priv, &xen_9pfs_devs, list))
return -EINVAL; return -EINVAL;
num = p9_req->tc.tag % priv->num_rings; num = p9_req->tc.tag % priv->num_rings;