selftests: gpio: return Kselftest Skip code for skipped tests
When gpio test is skipped because of unmet dependencies and/or unsupported configuration, it exits with error which is treated as a fail by the Kselftest framework. This leads to false negative result even when the test could not be run. Change it to return kselftest skip code when a test gets skipped to clearly report that the test could not be run. Kselftest framework SKIP code is 4 and the framework prints appropriate messages to indicate that the test is skipped. Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
This commit is contained in:
@@ -2,10 +2,11 @@
|
|||||||
# SPDX-License-Identifier: GPL-2.0
|
# SPDX-License-Identifier: GPL-2.0
|
||||||
|
|
||||||
#exit status
|
#exit status
|
||||||
#1: run as non-root user
|
#1: Internal error
|
||||||
#2: sysfs/debugfs not mount
|
#2: sysfs/debugfs not mount
|
||||||
#3: insert module fail when gpio-mockup is a module.
|
#3: insert module fail when gpio-mockup is a module.
|
||||||
#4: other reason.
|
#4: Skip test including run as non-root user.
|
||||||
|
#5: other reason.
|
||||||
|
|
||||||
SYSFS=
|
SYSFS=
|
||||||
GPIO_SYSFS=
|
GPIO_SYSFS=
|
||||||
@@ -15,6 +16,9 @@ GPIO_DEBUGFS=
|
|||||||
dev_type=
|
dev_type=
|
||||||
module=
|
module=
|
||||||
|
|
||||||
|
# Kselftest framework requirement - SKIP code is 4.
|
||||||
|
ksft_skip=4
|
||||||
|
|
||||||
usage()
|
usage()
|
||||||
{
|
{
|
||||||
echo "Usage:"
|
echo "Usage:"
|
||||||
@@ -34,7 +38,7 @@ prerequisite()
|
|||||||
msg="skip all tests:"
|
msg="skip all tests:"
|
||||||
if [ $UID != 0 ]; then
|
if [ $UID != 0 ]; then
|
||||||
echo $msg must be run as root >&2
|
echo $msg must be run as root >&2
|
||||||
exit 1
|
exit $ksft_skip
|
||||||
fi
|
fi
|
||||||
SYSFS=`mount -t sysfs | head -1 | awk '{ print $3 }'`
|
SYSFS=`mount -t sysfs | head -1 | awk '{ print $3 }'`
|
||||||
if [ ! -d "$SYSFS" ]; then
|
if [ ! -d "$SYSFS" ]; then
|
||||||
@@ -73,7 +77,7 @@ remove_module()
|
|||||||
die()
|
die()
|
||||||
{
|
{
|
||||||
remove_module
|
remove_module
|
||||||
exit 4
|
exit 5
|
||||||
}
|
}
|
||||||
|
|
||||||
test_chips()
|
test_chips()
|
||||||
|
|||||||
Reference in New Issue
Block a user