inet: kill smallest_size and smallest_port

In inet_csk_get_port we seem to be using smallest_port to figure out where the
best place to look for a SO_REUSEPORT sk that matches with an existing set of
SO_REUSEPORT's.  However if we get to the logic

if (smallest_size != -1) {
	port = smallest_port;
	goto have_port;
}

we will do a useless search, because we would have already done the
inet_csk_bind_conflict for that port and it would have returned 1, otherwise we
would have gone to found_tb and succeeded.  Since this logic makes us do yet
another trip through inet_csk_bind_conflict for a port we know won't work just
delete this code and save us the time.

Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

This commit is contained in:

Josef Bacik

2017-01-17 07:51:03 -08:00

committed by

David S. Miller

parent aa078842b7

commit b9470c2760

3 changed files with 4 additions and 26 deletions

									
										include/net/inet_hashtables.h
									
		-1
	
												View File
												
				@@ -80,7 +80,6 @@ struct inet_bind_bucket {

					signed char		fastreuse;

					signed char		fastreuseport;

					kuid_t			fastuid;

					int			num_owners;

					struct hlist_node	node;

					struct hlist_head	owners;

				};