PM: AVS: qcom-cpr: Fix an error handling path in cpr_probe()
[ Upstream commit6049aae523] If an error occurs after a successful pm_genpd_init() call, it should be undone by a corresponding pm_genpd_remove(). Add the missing call in the error handling path, as already done in the remove function. Fixes:bf6910abf5("power: avs: Add support for CPR (Core Power Reduction)") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/0f520597dbad89ab99c217c8986912fa53eaf5f9.1671293108.git.christophe.jaillet@wanadoo.fr Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
39ab0fc498
commit
b18490138d
@@ -1743,12 +1743,16 @@ static int cpr_probe(struct platform_device *pdev)
|
|||||||
|
|
||||||
ret = of_genpd_add_provider_simple(dev->of_node, &drv->pd);
|
ret = of_genpd_add_provider_simple(dev->of_node, &drv->pd);
|
||||||
if (ret)
|
if (ret)
|
||||||
return ret;
|
goto err_remove_genpd;
|
||||||
|
|
||||||
platform_set_drvdata(pdev, drv);
|
platform_set_drvdata(pdev, drv);
|
||||||
cpr_debugfs_init(drv);
|
cpr_debugfs_init(drv);
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
err_remove_genpd:
|
||||||
|
pm_genpd_remove(&drv->pd);
|
||||||
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int cpr_remove(struct platform_device *pdev)
|
static int cpr_remove(struct platform_device *pdev)
|
||||||
|
|||||||
Reference in New Issue
Block a user