TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bluetooth: hci_ll: Use skb_put_u8 instead of struct hcill_cmd

Browse Source 
The struct hcill_cmd to create an skb with a single u8 is pointless. So
just use skb_put_u8 instead.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
This commit is contained in:
Marcel Holtmann
2018-03-20 09:31:04 +01:00
parent 9376e4a5a3
commit 9bef22fb00
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/bluetooth/hci_ll.c
+1 -7
View File
@@ -82,10 +82,6 @@ enum hcill_states_e {
HCILL_AWAKE_TO_ASLEEP HCILL_AWAKE_TO_ASLEEP
}; };
struct hcill_cmd {
u8 cmd;
} __packed;
struct ll_device { struct ll_device {
struct hci_uart hu; struct hci_uart hu;
struct serdev_device *serdev; struct serdev_device *serdev;
@@ -113,7 +109,6 @@ static int send_hcill_cmd(u8 cmd, struct hci_uart *hu)
int err = 0; int err = 0;
struct sk_buff *skb = NULL; struct sk_buff *skb = NULL;
struct ll_struct *ll = hu->priv; struct ll_struct *ll = hu->priv;
struct hcill_cmd *hcill_packet;
BT_DBG("hu %p cmd 0x%x", hu, cmd); BT_DBG("hu %p cmd 0x%x", hu, cmd);
@@ -126,8 +121,7 @@ static int send_hcill_cmd(u8 cmd, struct hci_uart *hu)
} }
/* prepare packet */ /* prepare packet */
hcill_packet = skb_put(skb, 1); skb_put_u8(skb, cmd);
hcill_packet->cmd = cmd;
/* send packet */ /* send packet */
skb_queue_tail(&ll->txq, skb); skb_queue_tail(&ll->txq, skb);