From 87acf4924e1bb384226ef2e8bb6e090a5d51d733 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Sat, 13 Nov 2021 14:37:26 +0100 Subject: [PATCH] ANDROID: GKI: fix up abi break in ehci code Commit 94e5305a3816 ("usb: ehci: handshake CMD_RUN instead of STS_HALT") that got added into 5.10.79, added a new bitfield to the struct ehci_hcd structure. This bitfield is only used by the ehci core, and does not change the size of the structure overall at all, so comment it properly so that the CRC of any ehci functions do not change, and update the .xml file with the newly added bitfield: Leaf changes summary: 1 artifact changed Changed leaf types summary: 1 leaf type changed Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 0 Added function Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable 'struct ehci_hcd at ehci.h:111:1' changed: type size hasn't changed 1 data member insertion: 'unsigned int is_aspeed', at offset 15 (in bits) at ehci.h:226:1 one impacted interface Bug: 161946584 Fixes: 94e5305a3816 ("usb: ehci: handshake CMD_RUN instead of STS_HALT") Signed-off-by: Greg Kroah-Hartman Change-Id: Id5d3a9324d9a15f8baaf4aefedda786ed6d949c2 --- android/abi_gki_aarch64.xml | 299 ++++++++++++++++++------------------ drivers/usb/host/ehci.h | 6 + 2 files changed, 157 insertions(+), 148 deletions(-) diff --git a/android/abi_gki_aarch64.xml b/android/abi_gki_aarch64.xml index 8720cb9c767e..0cde5a0ddf9e 100755 --- a/android/abi_gki_aarch64.xml +++ b/android/abi_gki_aarch64.xml @@ -6463,24 +6463,24 @@ - + - + - + - + - + - + - + @@ -22466,42 +22466,42 @@ - + - + - + - + - + - + - + - + - + - + - + - + - + @@ -33506,48 +33506,48 @@ - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + @@ -34341,57 +34341,57 @@ - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + @@ -36451,33 +36451,33 @@ - + - + - + - + - + - + - + - + - + - + @@ -72646,32 +72646,35 @@ + + + - + - + - + - + - + - + - + - + - + @@ -75314,51 +75317,51 @@ - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + @@ -99742,33 +99745,33 @@ - + - + - + - + - + - + - + - + - + - + @@ -106794,15 +106797,15 @@ - + - + - + - + @@ -111144,18 +111147,18 @@ - + - + - + - + - + @@ -114048,8 +114051,8 @@ - - + + @@ -119371,19 +119374,19 @@ - + - - + + - - + + - + @@ -125397,13 +125400,13 @@ - - - + + + - - + + @@ -128625,7 +128628,7 @@ - + @@ -128958,32 +128961,32 @@ - - - - - - + + + + + + - - - - - - + + + + + + - - + + - - + + - - + + @@ -133653,14 +133656,14 @@ - - + + - - - + + + @@ -134244,8 +134247,8 @@ - - + + @@ -140055,8 +140058,8 @@ - - + + diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index 59fd523c55f3..55e517248af7 100644 --- a/drivers/usb/host/ehci.h +++ b/drivers/usb/host/ehci.h @@ -218,7 +218,13 @@ struct ehci_hcd { /* one per controller */ unsigned frame_index_bug:1; /* MosChip (AKA NetMos) */ unsigned need_oc_pp_cycle:1; /* MPC834X port power */ unsigned imx28_write_fix:1; /* For Freescale i.MX28 */ + /* + * __GENKSYMS__ test is an abi workaround for commit + * 7f2d73788d90 ("usb: ehci: handshake CMD_RUN * instead of STS_HALT") + */ +#ifndef __GENKSYMS__ unsigned is_aspeed:1; +#endif /* required for usb32 quirk */ #define OHCI_CTRL_HCFS (3 << 6)