TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs()

Browse Source 
Ensure that all error handling branches print error information. In this
way, when this function fails, the upper-layer functions can directly
return an error code without missing debugging information. Otherwise,
the error message will be printed redundantly or missing.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230620090732.50025-1-frank.li@vivo.com
This commit is contained in:
Yangtao Li
2023-06-20 17:07:22 +08:00
committed by Daniel Lezcano
parent 2ef9533134
commit 8416ecfb32
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/thermal/thermal_hwmon.c
+4 -1
View File
@@ -271,11 +271,14 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device
ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr), ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr),
GFP_KERNEL); GFP_KERNEL);
if (!ptr) if (!ptr) {
dev_warn(dev, "Failed to allocate device resource data\n");
return -ENOMEM; return -ENOMEM;
}
ret = thermal_add_hwmon_sysfs(tz); ret = thermal_add_hwmon_sysfs(tz);
if (ret) { if (ret) {
dev_warn(dev, "Failed to add hwmon sysfs attributes\n");
devres_free(ptr); devres_free(ptr);
return ret; return ret;
} }