bridge: multicast port group RCU fix
The recently introduced bridge mulitcast port group list was only partially using RCU correctly. It was missing rcu_dereference() and missing the necessary barrier on deletion. The code should have used one of the standard list methods (list or hlist) instead of open coding a RCU based link list. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
168d40ee3d
commit
83f6a740b4
@@ -259,7 +259,7 @@ static void br_multicast_del_pg(struct net_bridge *br,
|
||||
if (p != pg)
|
||||
continue;
|
||||
|
||||
*pp = p->next;
|
||||
rcu_assign_pointer(*pp, p->next);
|
||||
hlist_del_init(&p->mglist);
|
||||
del_timer(&p->timer);
|
||||
del_timer(&p->query_timer);
|
||||
|
||||
Reference in New Issue
Block a user