TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

btrfs: return early from failed memory allocations in ioctl handlers

Browse Source 
There is no need to call kfree() if memdup_user() fails, as no memory
was allocated and the error in the error-valued pointer should be returned.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
[ edit subject ]
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Shailendra Verma
2016-11-10 15:17:41 +05:30
committed by David Sterba
parent 58e8012cc1
commit 7b9ea6279b
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/btrfs/ioctl.c
+6 -15
View File
@@ -4569,11 +4569,8 @@ static long btrfs_ioctl_logical_to_ino(struct btrfs_root *root,
return -EPERM; return -EPERM;
loi = memdup_user(arg, sizeof(*loi)); loi = memdup_user(arg, sizeof(*loi));
if (IS_ERR(loi)) { if (IS_ERR(loi))
ret = PTR_ERR(loi); return PTR_ERR(loi);
loi = NULL;
goto out;
}
path = btrfs_alloc_path(); path = btrfs_alloc_path();
if (!path) { if (!path) {
@@ -5200,11 +5197,8 @@ static long btrfs_ioctl_set_received_subvol_32(struct file *file,
int ret = 0; int ret = 0;
args32 = memdup_user(arg, sizeof(*args32)); args32 = memdup_user(arg, sizeof(*args32));
if (IS_ERR(args32)) { if (IS_ERR(args32))
ret = PTR_ERR(args32); return PTR_ERR(args32);
args32 = NULL;
goto out;
}
args64 = kmalloc(sizeof(*args64), GFP_KERNEL); args64 = kmalloc(sizeof(*args64), GFP_KERNEL);
if (!args64) { if (!args64) {
@@ -5252,11 +5246,8 @@ static long btrfs_ioctl_set_received_subvol(struct file *file,
int ret = 0; int ret = 0;
sa = memdup_user(arg, sizeof(*sa)); sa = memdup_user(arg, sizeof(*sa));
if (IS_ERR(sa)) { if (IS_ERR(sa))
ret = PTR_ERR(sa); return PTR_ERR(sa);
sa = NULL;
goto out;
}
ret = _btrfs_ioctl_set_received_subvol(file, sa); ret = _btrfs_ioctl_set_received_subvol(file, sa);