TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dmaengine: at_xdmac: Fix concurrency over xfers_list

Browse Source 
commit 18deddea91 upstream.

Since tx_submit can be called from a hard IRQ, xfers_list must be
protected with a lock to avoid concurency on the list's elements.
Since at_xdmac_handle_cyclic() is called from a tasklet, spin_lock_irq
is enough to protect from a hard IRQ.

Fixes: e1f7c9eee7 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20211215110115.191749-8-tudor.ambarus@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tudor Ambarus
2021-12-15 13:01:10 +02:00
committed by Greg Kroah-Hartman
parent b5b27c5e33
commit 7ab120636d
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/dma/at_xdmac.c
+10 -7
View File
@@ -1559,14 +1559,17 @@ static void at_xdmac_handle_cyclic(struct at_xdmac_chan *atchan)
struct at_xdmac_desc *desc; struct at_xdmac_desc *desc;
struct dma_async_tx_descriptor *txd; struct dma_async_tx_descriptor *txd;
if (!list_empty(&atchan->xfers_list)) { spin_lock_irq(&atchan->lock);
desc = list_first_entry(&atchan->xfers_list, if (list_empty(&atchan->xfers_list)) {
struct at_xdmac_desc, xfer_node); spin_unlock_irq(&atchan->lock);
txd = &desc->tx_dma_desc; return;
if (txd->flags & DMA_PREP_INTERRUPT)
dmaengine_desc_get_callback_invoke(txd, NULL);
} }
desc = list_first_entry(&atchan->xfers_list, struct at_xdmac_desc,
xfer_node);
spin_unlock_irq(&atchan->lock);
txd = &desc->tx_dma_desc;
if (txd->flags & DMA_PREP_INTERRUPT)
dmaengine_desc_get_callback_invoke(txd, NULL);
} }
static void at_xdmac_handle_error(struct at_xdmac_chan *atchan) static void at_xdmac_handle_error(struct at_xdmac_chan *atchan)