hrtimer: prevent overrun DoS in hrtimer_forward()
hrtimer_forward() does not check for the possible overflow of timer->expires. This can happen on 64 bit machines with large interval values and results currently in an endless loop in the softirq because the expiry value becomes negative and therefor the timer is expired all the time. Check for this condition and set the expiry value to the max. expiry time in the future. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Adrian Bunk <bunk@stusta.de>
This commit is contained in:
committed by
Adrian Bunk
parent
19b5054d01
commit
75da4e6426
@@ -316,6 +316,12 @@ hrtimer_forward(struct hrtimer *timer, ktime_t interval)
|
||||
orun++;
|
||||
}
|
||||
timer->expires = ktime_add(timer->expires, interval);
|
||||
/*
|
||||
* Make sure, that the result did not wrap with a very large
|
||||
* interval.
|
||||
*/
|
||||
if (timer->expires.tv64 < 0)
|
||||
timer->expires = ktime_set(KTIME_SEC_MAX, 0);
|
||||
|
||||
return orun;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user