TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remoteproc: k3-r5: Fix refcount leak in k3_r5_cluster_of_init

Browse Source 
[ Upstream commit fa220c05d2 ]

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node.
When breaking early from a for_each_available_child_of_node() loop,
we need to explicitly call of_node_put() on the child node.
Add missing of_node_put() to avoid refcount leak.

Fixes: 6dedbd1d54 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Suman Anna <s-anna@ti.com>
Link: https://lore.kernel.org/r/20220605083334.23942-1-linmq006@gmail.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miaoqian Lin
2022-06-05 12:33:34 +04:00
committed by Greg Kroah-Hartman
parent 2aa8737d49
commit 75358732af
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/remoteproc/ti_k3_r5_remoteproc.c
+2
View File
@@ -1283,6 +1283,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
if (!cpdev) { if (!cpdev) {
ret = -ENODEV; ret = -ENODEV;
dev_err(dev, "could not get R5 core platform device\n"); dev_err(dev, "could not get R5 core platform device\n");
of_node_put(child);
goto fail; goto fail;
} }
@@ -1291,6 +1292,7 @@ static int k3_r5_cluster_of_init(struct platform_device *pdev)
dev_err(dev, "k3_r5_core_of_init failed, ret = %d\n", dev_err(dev, "k3_r5_core_of_init failed, ret = %d\n",
ret); ret);
put_device(&cpdev->dev); put_device(&cpdev->dev);
of_node_put(child);
goto fail; goto fail;
} }