lightnvm: pblk: check for chunk size before allocating it
Do the check for the chunk state after making sure that the chunk type
is supported.
Fixes: 32ef9412c1 ("lightnvm: pblk: implement get log report chunk")
Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
committed by
Jens Axboe
parent
8e55c07b2b
commit
6f9c9607d4
@@ -751,14 +751,14 @@ static int pblk_setup_line_meta_20(struct pblk *pblk, struct pblk_line *line,
|
|||||||
chunk->cnlb = chunk_meta->cnlb;
|
chunk->cnlb = chunk_meta->cnlb;
|
||||||
chunk->wp = chunk_meta->wp;
|
chunk->wp = chunk_meta->wp;
|
||||||
|
|
||||||
if (!(chunk->state & NVM_CHK_ST_OFFLINE))
|
|
||||||
continue;
|
|
||||||
|
|
||||||
if (chunk->type & NVM_CHK_TP_SZ_SPEC) {
|
if (chunk->type & NVM_CHK_TP_SZ_SPEC) {
|
||||||
WARN_ONCE(1, "pblk: custom-sized chunks unsupported\n");
|
WARN_ONCE(1, "pblk: custom-sized chunks unsupported\n");
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!(chunk->state & NVM_CHK_ST_OFFLINE))
|
||||||
|
continue;
|
||||||
|
|
||||||
set_bit(pos, line->blk_bitmap);
|
set_bit(pos, line->blk_bitmap);
|
||||||
nr_bad_chks++;
|
nr_bad_chks++;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user