TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: bcmgenet: Fix return value check for fixed_phy_register()

Browse Source 
[ Upstream commit 32bbe64a13 ]

The fixed_phy_register() function returns error pointers and never
returns NULL. Update the checks accordingly.

Fixes: b0ba512e25 ("net: bcmgenet: enable driver to work without a device tree")
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ruan Jinjie
2023-08-18 13:12:21 +08:00
committed by Greg Kroah-Hartman
parent 92b20b1569
commit 67c8d7ef54
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ethernet/broadcom/genet/bcmmii.c
+1 -1
View File
@@ -568,7 +568,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)
}; };
phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
if (!phydev || IS_ERR(phydev)) { if (IS_ERR(phydev)) {
dev_err(kdev, "failed to register fixed PHY device\n"); dev_err(kdev, "failed to register fixed PHY device\n");
return -ENODEV; return -ENODEV;
} }