TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

exportfs: add helpers to check if filesystem can encode/decode file handles

Browse Source 
The logic of whether filesystem can encode/decode file handles is open
coded in many places.

In preparation to changing the logic, move the open coded logic into
inline helpers.

Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/r/20231023180801.2953446-2-amir73il@gmail.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Amir Goldstein
2023-10-23 21:07:58 +03:00
committed by Christian Brauner
parent 05d3ef8bba
commit 66c62769bc
6 changed files with 34 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/exportfs/expfs.c
+2 -6
View File
@@ -396,11 +396,7 @@ int exportfs_encode_inode_fh(struct inode *inode, struct fid *fid,
{
const struct export_operations *nop = inode->i_sb->s_export_op;
/*
* If a decodeable file handle was requested, we need to make sure that
* filesystem can decode file handles.
*/
if (nop && !(flags & EXPORT_FH_FID) && !nop->fh_to_dentry)
if (!exportfs_can_encode_fh(nop, flags))
return -EOPNOTSUPP;
if (nop && nop->encode_fh)
@@ -456,7 +452,7 @@ exportfs_decode_fh_raw(struct vfsmount *mnt, struct fid *fid, int fh_len,
/*
* Try to get any dentry for the given file handle from the filesystem.
*/
if (!nop || !nop->fh_to_dentry)
if (!exportfs_can_decode_fh(nop))
return ERR_PTR(-ESTALE);
result = nop->fh_to_dentry(mnt->mnt_sb, fid, fh_len, fileid_type);
if (IS_ERR_OR_NULL(result))