TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nfsd4: fix cr_principal comparison check in same_creds

Browse Source 
This fixes a wrong check for same cr_principal in same_creds

Introduced by 8fbba96e5b "nfsd4: stricter
cred comparison for setclientid/exchange_id".

Cc: stable@vger.kernel.org
Signed-off-by: Vivek Trivedi <vtrivedi018@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
Vivek Trivedi
2012-07-24 21:18:20 +05:30
committed by J. Bruce Fields
parent 200724a707
commit 5559b50acd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/nfsd/nfs4state.c
+2 -2
View File
@@ -1221,7 +1221,7 @@ static bool groups_equal(struct group_info *g1, struct group_info *g2)
return true; return true;
} }
static int static bool
same_creds(struct svc_cred *cr1, struct svc_cred *cr2) same_creds(struct svc_cred *cr1, struct svc_cred *cr2)
{ {
if ((cr1->cr_flavor != cr2->cr_flavor) if ((cr1->cr_flavor != cr2->cr_flavor)
@@ -1233,7 +1233,7 @@ same_creds(struct svc_cred *cr1, struct svc_cred *cr2)
return true; return true;
if (!cr1->cr_principal || !cr2->cr_principal) if (!cr1->cr_principal || !cr2->cr_principal)
return false; return false;
return 0 == strcmp(cr1->cr_principal, cr1->cr_principal); return 0 == strcmp(cr1->cr_principal, cr2->cr_principal);
} }
static void gen_clid(struct nfs4_client *clp) static void gen_clid(struct nfs4_client *clp)