Merge tag 'char-misc-5.13-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
Pull char/misc driver fixes from Greg KH: "Here is a big set of char/misc/other driver fixes for 5.13-rc3. The majority here is the fallout of the umn.edu re-review of all prior submissions. That resulted in a bunch of reverts along with the "correct" changes made, such that there is no regression of any of the potential fixes that were made by those individuals. I would like to thank the over 80 different developers who helped with the review and fixes for this mess. Other than that, there's a few habanna driver fixes for reported issues, and some dyndbg fixes for reported problems. All of these have been in linux-next for a while with no reported problems" * tag 'char-misc-5.13-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (82 commits) misc: eeprom: at24: check suspend status before disable regulator uio_hv_generic: Fix another memory leak in error handling paths uio_hv_generic: Fix a memory leak in error handling paths uio/uio_pci_generic: fix return value changed in refactoring Revert "Revert "ALSA: usx2y: Fix potential NULL pointer dereference"" dyndbg: drop uninformative vpr_info dyndbg: avoid calling dyndbg_emit_prefix when it has no work binder: Return EFAULT if we fail BINDER_ENABLE_ONEWAY_SPAM_DETECTION cdrom: gdrom: initialize global variable at init time brcmfmac: properly check for bus register errors Revert "brcmfmac: add a check for the status of usb_register" video: imsttfb: check for ioremap() failures Revert "video: imsttfb: fix potential NULL pointer dereferences" net: liquidio: Add missing null pointer checks Revert "net: liquidio: fix a NULL pointer dereference" media: gspca: properly check for errors in po1030_probe() Revert "media: gspca: Check the return value of write_bridge for timeout" media: gspca: mt9m111: Check write_bridge for timeout Revert "media: gspca: mt9m111: Check write_bridge for timeout" media: dvb: Add check on sp8870_readreg return ...
This commit is contained in:
+12
-8
@@ -586,13 +586,11 @@ static int remaining(int wrote)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static char *dynamic_emit_prefix(const struct _ddebug *desc, char *buf)
|
||||
static char *__dynamic_emit_prefix(const struct _ddebug *desc, char *buf)
|
||||
{
|
||||
int pos_after_tid;
|
||||
int pos = 0;
|
||||
|
||||
*buf = '\0';
|
||||
|
||||
if (desc->flags & _DPRINTK_FLAGS_INCL_TID) {
|
||||
if (in_interrupt())
|
||||
pos += snprintf(buf + pos, remaining(pos), "<intr> ");
|
||||
@@ -618,11 +616,18 @@ static char *dynamic_emit_prefix(const struct _ddebug *desc, char *buf)
|
||||
return buf;
|
||||
}
|
||||
|
||||
static inline char *dynamic_emit_prefix(struct _ddebug *desc, char *buf)
|
||||
{
|
||||
if (unlikely(desc->flags & _DPRINTK_FLAGS_INCL_ANY))
|
||||
return __dynamic_emit_prefix(desc, buf);
|
||||
return buf;
|
||||
}
|
||||
|
||||
void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...)
|
||||
{
|
||||
va_list args;
|
||||
struct va_format vaf;
|
||||
char buf[PREFIX_SIZE];
|
||||
char buf[PREFIX_SIZE] = "";
|
||||
|
||||
BUG_ON(!descriptor);
|
||||
BUG_ON(!fmt);
|
||||
@@ -655,7 +660,7 @@ void __dynamic_dev_dbg(struct _ddebug *descriptor,
|
||||
if (!dev) {
|
||||
printk(KERN_DEBUG "(NULL device *): %pV", &vaf);
|
||||
} else {
|
||||
char buf[PREFIX_SIZE];
|
||||
char buf[PREFIX_SIZE] = "";
|
||||
|
||||
dev_printk_emit(LOGLEVEL_DEBUG, dev, "%s%s %s: %pV",
|
||||
dynamic_emit_prefix(descriptor, buf),
|
||||
@@ -684,7 +689,7 @@ void __dynamic_netdev_dbg(struct _ddebug *descriptor,
|
||||
vaf.va = &args;
|
||||
|
||||
if (dev && dev->dev.parent) {
|
||||
char buf[PREFIX_SIZE];
|
||||
char buf[PREFIX_SIZE] = "";
|
||||
|
||||
dev_printk_emit(LOGLEVEL_DEBUG, dev->dev.parent,
|
||||
"%s%s %s %s%s: %pV",
|
||||
@@ -720,7 +725,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
|
||||
vaf.va = &args;
|
||||
|
||||
if (ibdev && ibdev->dev.parent) {
|
||||
char buf[PREFIX_SIZE];
|
||||
char buf[PREFIX_SIZE] = "";
|
||||
|
||||
dev_printk_emit(LOGLEVEL_DEBUG, ibdev->dev.parent,
|
||||
"%s%s %s %s: %pV",
|
||||
@@ -915,7 +920,6 @@ static const struct seq_operations ddebug_proc_seqops = {
|
||||
|
||||
static int ddebug_proc_open(struct inode *inode, struct file *file)
|
||||
{
|
||||
vpr_info("called\n");
|
||||
return seq_open_private(file, &ddebug_proc_seqops,
|
||||
sizeof(struct ddebug_iter));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user