TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/mgag200: Remove unecessary NULL check in gem_free

Browse Source 
The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Daniel Vetter
2014-04-05 10:06:16 +02:00
parent 36b347fb31
commit 4cb8802e28
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/gpu/drm/mgag200/mgag200_main.c
-2
View File
@@ -329,8 +329,6 @@ void mgag200_gem_free_object(struct drm_gem_object *obj)
{ {
struct mgag200_bo *mgag200_bo = gem_to_mga_bo(obj); struct mgag200_bo *mgag200_bo = gem_to_mga_bo(obj);
if (!mgag200_bo)
return;
mgag200_bo_unref(&mgag200_bo); mgag200_bo_unref(&mgag200_bo);
} }