TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ieee802154: hwsim: Fix possible memory leaks

Browse Source 
[ Upstream commit a616752947 ]

After replacing e->info, it is necessary to free the old einfo.

Fixes: f25da51fdc ("ieee802154: hwsim: add replacement for fakelb")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: Chen Aotian <chenaotian2@163.com>
Link: https://lore.kernel.org/r/20230409022048.61223-1-chenaotian2@163.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Chen Aotian
2023-04-09 10:20:48 +08:00
committed by Greg Kroah-Hartman
parent 051d642133
commit 47be2931c4
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ieee802154/mac802154_hwsim.c
+4 -2
View File
@@ -522,7 +522,7 @@ static int hwsim_del_edge_nl(struct sk_buff *msg, struct genl_info *info)
static int hwsim_set_edge_lqi(struct sk_buff *msg, struct genl_info *info) static int hwsim_set_edge_lqi(struct sk_buff *msg, struct genl_info *info)
{ {
struct nlattr *edge_attrs[MAC802154_HWSIM_EDGE_ATTR_MAX + 1]; struct nlattr *edge_attrs[MAC802154_HWSIM_EDGE_ATTR_MAX + 1];
struct hwsim_edge_info *einfo; struct hwsim_edge_info *einfo, *einfo_old;
struct hwsim_phy *phy_v0; struct hwsim_phy *phy_v0;
struct hwsim_edge *e; struct hwsim_edge *e;
u32 v0, v1; u32 v0, v1;
@@ -560,8 +560,10 @@ static int hwsim_set_edge_lqi(struct sk_buff *msg, struct genl_info *info)
list_for_each_entry_rcu(e, &phy_v0->edges, list) { list_for_each_entry_rcu(e, &phy_v0->edges, list) {
if (e->endpoint->idx == v1) { if (e->endpoint->idx == v1) {
einfo->lqi = lqi; einfo->lqi = lqi;
rcu_assign_pointer(e->info, einfo); einfo_old = rcu_replace_pointer(e->info, einfo,
lockdep_is_held(&hwsim_phys_lock));
rcu_read_unlock(); rcu_read_unlock();
kfree_rcu(einfo_old, rcu);
mutex_unlock(&hwsim_phys_lock); mutex_unlock(&hwsim_phys_lock);
return 0; return 0;
} }