NTB: ntb_transport: fix possible memory leak while device_register() fails
[ Upstream commit8623ccbfc5] If device_register() returns error, the name allocated by dev_set_name() need be freed. As comment of device_register() says, it should use put_device() to give up the reference in the error path. So fix this by calling put_device(), then the name can be freed in kobject_cleanup(), and client_dev is freed in ntb_transport_client_release(). Fixes:fce8a7bb5b("PCI-Express Non-Transparent Bridge Support") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
03cfa06534
commit
41c6d8ff71
@@ -412,7 +412,7 @@ int ntb_transport_register_client_dev(char *device_name)
|
|||||||
|
|
||||||
rc = device_register(dev);
|
rc = device_register(dev);
|
||||||
if (rc) {
|
if (rc) {
|
||||||
kfree(client_dev);
|
put_device(dev);
|
||||||
goto err;
|
goto err;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user