TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

OMAP: DSS2: OMAPFB: make DBG() more resistant in if-else constructions

Browse Source 
When DBG() is used in a simple if-else, the resulting code path
currently depends on the definition of DBG(). Inserting the statement in
a "do { ... } while (0)" prevents this possible misuse.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
[tomi.valkeinen@ti.com: changed the title of the commit msg]
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Niels de Vos
2011-05-10 12:07:33 +01:00
committed by Tomi Valkeinen
parent 0d548a277c
commit 41b21aebe6
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/video/omap2/omapfb/omapfb.h
+4 -2
View File
@@ -34,8 +34,10 @@
#ifdef DEBUG #ifdef DEBUG
extern unsigned int omapfb_debug; extern unsigned int omapfb_debug;
#define DBG(format, ...) \ #define DBG(format, ...) \
if (omapfb_debug) \ do { \
printk(KERN_DEBUG "OMAPFB: " format, ## __VA_ARGS__) if (omapfb_debug) \
printk(KERN_DEBUG "OMAPFB: " format, ## __VA_ARGS__); \
} while (0)
#else #else
#define DBG(format, ...) #define DBG(format, ...)
#endif #endif