TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ovl: don't set the superblock's errseq_t manually

Browse Source 
Since commit 5679897eb104 ("vfs: make sync_filesystem return errors from
->sync_fs"), the return value from sync_fs callback can be seen in
sync_filesystem(). Thus the errseq_set opreation can be removed here.

Depends-on: commit 5679897eb104 ("vfs: make sync_filesystem return errors from ->sync_fs")
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
This commit is contained in:
Haifeng Xu 2024-07-30 12:20:08 +08:00 committed by Amir Goldstein
parent 3e9bff3bbe
commit 34b4540e66
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/overlayfs/super.c
View File

@ -202,15 +202,9 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
int ret; int ret;
ret = ovl_sync_status(ofs); ret = ovl_sync_status(ofs);
/*
* We have to always set the err, because the return value isn't if (ret < 0)
* checked in syncfs, and instead indirectly return an error via
* the sb's writeback errseq, which VFS inspects after this call.
*/
if (ret < 0) {
errseq_set(&sb->s_wb_err, -EIO);
return -EIO; return -EIO;
}
if (!ret) if (!ret)
return ret; return ret;