net: designate queue -> napi linking as "ops protected"
netdev netlink is the only reader of netdev_{,rx_}queue->napi,
and it already holds netdev->lock. Switch protection of
the writes to netdev->lock to "ops protected".
The expectation will be now that accessing queue->napi
will require netdev->lock for "ops locked" drivers, and
rtnl_lock for all other drivers.
Current "ops locked" drivers don't require any changes.
gve and netdevsim use _locked() helpers right next to
netif_queue_set_napi() so they must be holding the instance
lock. iavf doesn't call it. bnxt is a bit messy but all paths
seem locked.
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250324224537.248800-7-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
@@ -24,7 +24,7 @@ struct netdev_rx_queue {
|
||||
struct xsk_buff_pool *pool;
|
||||
#endif
|
||||
/* NAPI instance for the queue
|
||||
* Readers and writers must hold RTNL
|
||||
* "ops protected", see comment about net_device::lock
|
||||
*/
|
||||
struct napi_struct *napi;
|
||||
struct pp_memory_provider_params mp_params;
|
||||
|
||||
Reference in New Issue
Block a user