TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

netfilter: nf_nat_snmp_basic: fix duplicates in if/else branches

Browse Source 
The solution was found by Patrick in 2.4 kernel sources.

Cc: Patrick McHardy <kaber@trash.net>
Signed-off-by: Francois-Xavier Le Bail <fx.lebail@yahoo.com>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
FX Le Bail
2014-02-11 15:49:25 +01:00
committed by Pablo Neira Ayuso
parent 06efbd6d56
commit 2b7a79bae2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
net/ipv4/netfilter/nf_nat_snmp_basic.c
+2 -2
View File
@@ -1198,8 +1198,8 @@ static int snmp_translate(struct nf_conn *ct,
map.to = NOCT1(&ct->tuplehash[!dir].tuple.dst.u3.ip); map.to = NOCT1(&ct->tuplehash[!dir].tuple.dst.u3.ip);
} else { } else {
/* DNAT replies */ /* DNAT replies */
map.from = NOCT1(&ct->tuplehash[dir].tuple.src.u3.ip); map.from = NOCT1(&ct->tuplehash[!dir].tuple.src.u3.ip);
map.to = NOCT1(&ct->tuplehash[!dir].tuple.dst.u3.ip); map.to = NOCT1(&ct->tuplehash[dir].tuple.dst.u3.ip);
} }
if (map.from == map.to) if (map.from == map.to)