TWxSoftware/twx-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mfd: ab3100-core.c: Fix multiple warnings reported by Checkpatch

Browse Source 
WARNING: Missing a blank line after declarations
+       struct ab3100 *ab3100 = dev_get_drvdata(dev->parent);
+       if (!ab3100->startup_events_read)

WARNING: Possible unnecessary 'out of memory' message
+       if (!ab3100) {
+               dev_err(&client->dev, "could not allocate AB3100 device\n");

WARNING: else is not generally useful after a break or return
+                               break;
+                       } else {

total: 0 errors, 3 warnings, 996 lines checked

Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Lee Jones
2015-10-27 16:19:31 +00:00
parent 4374b20c6c
commit 15544cab28
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/mfd/ab3100-core.c
+10 -13
View File
@@ -381,9 +381,11 @@ static int ab3100_event_registers_startup_state_get(struct device *dev,
u8 *event) u8 *event)
{ {
struct ab3100 *ab3100 = dev_get_drvdata(dev->parent); struct ab3100 *ab3100 = dev_get_drvdata(dev->parent);
if (!ab3100->startup_events_read) if (!ab3100->startup_events_read)
return -EAGAIN; /* Try again later */ return -EAGAIN; /* Try again later */
memcpy(event, ab3100->startup_events, 3); memcpy(event, ab3100->startup_events, 3);
return 0; return 0;
} }
@@ -858,10 +860,8 @@ static int ab3100_probe(struct i2c_client *client,
int i; int i;
ab3100 = devm_kzalloc(&client->dev, sizeof(struct ab3100), GFP_KERNEL); ab3100 = devm_kzalloc(&client->dev, sizeof(struct ab3100), GFP_KERNEL);
if (!ab3100) { if (!ab3100)
dev_err(&client->dev, "could not allocate AB3100 device\n");
return -ENOMEM; return -ENOMEM;
}
/* Initialize data structure */ /* Initialize data structure */
mutex_init(&ab3100->access_mutex); mutex_init(&ab3100->access_mutex);
@@ -883,20 +883,17 @@ static int ab3100_probe(struct i2c_client *client,
for (i = 0; ids[i].id != 0x0; i++) { for (i = 0; ids[i].id != 0x0; i++) {
if (ids[i].id == ab3100->chip_id) { if (ids[i].id == ab3100->chip_id) {
if (ids[i].name != NULL) { if (ids[i].name)
snprintf(&ab3100->chip_name[0],
sizeof(ab3100->chip_name) - 1,
"AB3100 %s",
ids[i].name);
break; break;
} else {
dev_err(&client->dev, dev_err(&client->dev, "AB3000 is not supported\n");
"AB3000 is not supported\n"); goto exit_no_detect;
goto exit_no_detect;
}
} }
} }
snprintf(&ab3100->chip_name[0],
sizeof(ab3100->chip_name) - 1, "AB3100 %s", ids[i].name);
if (ids[i].id == 0x0) { if (ids[i].id == 0x0) {
dev_err(&client->dev, "unknown analog baseband chip id: 0x%x\n", dev_err(&client->dev, "unknown analog baseband chip id: 0x%x\n",
ab3100->chip_id); ab3100->chip_id);